Field photo > photoset not rendering anything [#2347101]

I've created a field of the type Flickr photo > photoset. When I configure the display if I try to change the value it will always save the first option which is "Square". When creating or editing a content with this field it will never render anything but it doesn't throw any error and the values are saved in the database. I've inserted the following values:

ID: 7215764450
User: 28633558@N06

The gallery is this: https://www.flickr.com/photos/leukaemia_research/sets/72157644505078276

Any help would be much appreciated, I could just print this using the theme function in the template but I prefer to do it in the right way rendering the field.

Please provide the steps necessary to replicate the issue in the sandbox.

Comment	File	Size	Author
#7	field_photo_photoset_not_rendering_anything-2347101-7.patch	1.56 KB	guardiola86
#4	photoset.png	11.04 KB	guardiola86
#4	field_photo_photoset_not_rendering_anything-2347101-4.patch	1.54 KB	guardiola86

Comments

Comment #1

lolandese commented 29 September 2014 at 21:19

Version:	7.x-1.6	» 7.x-1.x-dev
Priority:	Critical	» Major

I confirm the issue also in the current dev version. I'll see what I can do in the coming weekend. Feel free to investigate further. Supplied patches (or code snippets) are always committed with attribution.

Thanks for reporting.

Comment #2

guardiola86 commented 29 September 2014 at 22:15

I'll have a look tomorrow and maybe commit a patch for it. It was to confirm if it was an issue or not.

Comment #3

lolandese commented 30 September 2014 at 06:45

Just to define the issue a bit more:
Remember that the ID should be the complete number from the URL, thus 72157644505078276. In the sandbox it renders the 'square' but 'Manage display' (e.g. at /admin/structure/types/manage/page/display for the content type 'Basic page') doesn't seem have effect if changing it to another size.

Please confirm if this is the same issue as you described above. If not, describe the steps to reproduce this in the sandbox.

Thanks.

Comment #4

guardiola86 commented 30 September 2014 at 15:55

Status	File	Size
new	field_photo_photoset_not_rendering_anything-2347101-4.patch	1.54 KB
new	photoset.png	11.04 KB

I've fixed the problem with the rendering of the field photo > photoset (it wasn't rendering anything at all) and it's saving the values in the "Manage display" option. Anyway it still need work, when changing that value in the display options doesn't change anything.

Comment #5

guardiola86 commented 30 September 2014 at 15:58

Status:

Active

» Needs work

Comment #6

lolandese commented 1 October 2014 at 19:44

Patch applies cleanly:

martin@martin-X501A1:~/www/green/sites/all/modules/flickr$ git apply -v field_photo_photoset_not_rendering_anything-2347101-4.patch
Checking patch field/flickrfield.module...
Applied patch field/flickrfield.module cleanly.

Will test a 'Needs review' patch promptly.

Thanks for your help on this.

Comment #7

guardiola86 commented 23 October 2014 at 14:58

Status	File	Size
new	field_photo_photoset_not_rendering_anything-2347101-7.patch	1.56 KB

I've just updated the patch, as it was making the node break if the id was incorrect.

Comment #8

guardiola86 commented 23 October 2014 at 15:00

Status:

Needs work

» Needs review

Comment #9

lolandese commented 23 October 2014 at 20:26

Priority:	Major	» Normal
Status:	Needs review	» Needs work

Patch applies cleanly.

Testing the patched module on the sandbox. Steps followed:

Opened http://simplytest.me/project/flickr/7.x-1.x?patch[]=https://www.drupal.o... and launched it.
Log in.
At admin/modules enabled Flickr Field.
At admin/structure/types/manage/article/fields added a field 'Flickr Photo' (both 'label' and 'field type'). All values as offered by default.
At admin/config/media/flickr given a valid API key and secret.
At node/add/article cretaed a new Article 'Test' with 'Item type' = 'Photoset', 'Item id' = '72157644505078276' and 'User id' = '28633558@N06'.

Error messages:

Notice: Undefined index: photoset in theme_flickr_photoset() (line 633 of /home/s772d35a03e461f0/www/sites/default/modules/flickr/flickr.module).
Notice: Undefined index: size in theme_flickr_photoset() (line 635 of /home/s772d35a03e461f0/www/sites/default/modules/flickr/flickr.module).
Flickr error 1: Photo not found
Flickr error 1: Photo not found
Notice: Undefined index: photoset in theme_flickr_photoset() (line 633 of /home/s772d35a03e461f0/www/sites/default/modules/flickr/flickr.module).
Notice: Undefined index: size in theme_flickr_photoset() (line 635 of /home/s772d35a03e461f0/www/sites/default/modules/flickr/flickr.module).
Flickr error 1: Photo not found
Flickr error 1: Photo not found

No images are displayed.

=========================================================

The same without applying the patch:

Opened http://simplytest.me/project/flickr/7.x-1.x and launched it.
Log in.
At admin/modules enabled Flickr Field.
At admin/structure/types/manage/article/fields added a field 'Flickr Photo' (both 'label' and 'field type'). All values as offered by default.
At admin/config/media/flickr given a valid API key and secret.
At node/add/article cretaed a new Article 'Test' with 'Item type' = 'Photoset', 'Item id' = '72157644505078276' and 'User id' = '28633558@N06'.

No error messages.

One image gets displayed representing the set. Clicking it links to the photoset page on Flickr. This behaviour can be changed by enabling the Flickr Sets sub-module. This will show the first 6 images that are in the sample set (as defined in the configuration at admin/config/media/flickr).

Taking it one step further. At admin/structure/types/manage/article/display changing the 'format' to e.g. 'Small' has the desired effect but leads to an error message:

Notice: Undefined index: media in theme_flickr_photo() (line 541 of /home/s3b18872f62b851b/www/sites/default/modules/flickr/flickr.module).
Notice: Undefined index: media in theme_flickr_photo() (line 541 of /home/s3b18872f62b851b/www/sites/default/modules/flickr/flickr.module).
Notice: Undefined index: media in theme_flickr_photo() (line 541 of /home/s3b18872f62b851b/www/sites/default/modules/flickr/flickr.module).
Notice: Undefined index: media in theme_flickr_photo() (line 541 of /home/s3b18872f62b851b/www/sites/default/modules/flickr/flickr.module).
Notice: Undefined index: media in theme_flickr_photo() (line 541 of /home/s3b18872f62b851b/www/sites/default/modules/flickr/flickr.module).
Notice: Undefined index: media in theme_flickr_photo() (line 541 of /home/s3b18872f62b851b/www/sites/default/modules/flickr/flickr.module).

Six times. One for each image.

=======================================================

Please, try to give some steps to reproduce your experienced issue in the sandbox, as done above.

Then provide a patch that passes the test as described above.

Sorry for demanding this procedure, but this way we are sure that we have both the same environment and configuration.

Thanks.

Comment #10

guardiola86 commented 24 October 2014 at 09:20

Ok, I'll try to find some time next week to make a patch that fix everything and test it in the sandbox. Cheers.

Comment #11

lolandese commented 16 November 2014 at 17:22

Issue summary:	View changes
Status:	Needs work	» Closed (cannot reproduce)

The 'undefined index' error was unrelated and introduced with a recent commit. Corrected with http://cgit.drupalcode.org/flickr/commit/?id=6b2c18b.

The described steps above (without applying the patch) show that all works as expected on the sandbox. Flickr Photoset fields render and the images can be changed in size without problems.

Please provide the steps to replicate the issue in the sandbox.

Field photo > photoset not rendering anything