The installer instructs you to create settings.php and services.yml and make them writable. Later, it checks if settings.php is still writable and reminds you to fix it. It should do this for services.yml too (the status report does, but the installer doesn't).

CommentFileSizeAuthor
#15 installationSuccessful.png139.49 KBshwetaneelsharma
#15 2346803PatchResult.jpg279.88 KBshwetaneelsharma
#12 installer_doesn_t_warn-2346803-12.patch2.7 KBsushantpaste
#11 2346803-11.patch2.84 KBjohn morahan
#8 services-yml-warning.patch2.68 KBpythagory
#1 2346803.patch2.67 KBjohn morahan

Comments

john morahan’s picture

john morahan commented
Status: Active » Needs work
StatusFileSize
new 2346803.patch2.67 KB

Untested patch.

john morahan’s picture

john morahan commented
Status: Needs work » Needs review
andrefy’s picture

andrefy commented

Tested

andrefy’s picture

andrefy commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2346803.patch, failed testing.

jcuello’s picture

jcuello commented
Issue tags: +LatinAmerica2015, +Needs reroll

Hi, I've tried to apply the patch at #1But it does not apply.

pythagory’s picture

pythagory commented
Assigned: Unassigned » pythagory
pythagory’s picture

pythagory commented
Assigned: pythagory » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new services-yml-warning.patch2.68 KB

Re-rolled patch. Resolved merge conflict with updated services.yml check/warning in core/lib/Drupal/Core/Installer/Form/SiteConfigureForm.php

John Morahan queued 8: services-yml-warning.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 8: services-yml-warning.patch, failed testing.

john morahan’s picture

john morahan commented
Status: Needs work » Needs review
StatusFileSize
new 2346803-11.patch2.84 KB
sushantpaste’s picture

sushantpaste
Primary language Marathi
Location Sawantwadi India
commented
StatusFileSize
new installer_doesn_t_warn-2346803-12.patch2.7 KB

It works fine. Patch with minor formatting fix.

While testing this issue , I am not getting" installer instruction to create services.yml and make it writable " (getting only for settings.php file) I am not sure if I have missed anything for installation, can someone check this?

shwetaneelsharma’s picture

shwetaneelsharma commented

@sushantpaste: I guess you were re-installing drupal8 by renaming settings.php file. I don't think you will receive a message for services.yml if it is already present (created) in the directory.

sushantpaste’s picture

sushantpaste
Primary language Marathi
Location Sawantwadi India
commented

@shwetaneelsharma: Thanks. Yes I am reinstalling drupal8. So I think the patch works fine. If you reviewed patch can you marked it as RTBC.

shwetaneelsharma’s picture

shwetaneelsharma commented
StatusFileSize
new 2346803PatchResult.jpg279.88 KB
new installationSuccessful.png139.49 KB

Patch "installer_doesn_t_warn-2346803-12.patch" passes testing. Installer does warn about writable services.yml file also along with settings.php during the installation process. Attaching screenshot for passed result.

However, I would like to address a new problem here. Before I proceed with the final step of installation here, I am making both the files settings.php and services.yml read only. Now, after hitting the save/continue button, I am seeing the warning displayed for both the files on homepage. Attaching a screenshot.
This shouldn't happen because I had taken away the permissions before finishing the installation. Should this problem be addressed here or in a new ticket?

Thanks,
Shweta.

john morahan’s picture

john morahan commented

Actually, it looks like #12 is correct. Since #2547447: Stop creating services.yml by default the installer no longer requires this step at all.

So I think this issue can be closed, right?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs review » Closed (outdated)