Problem/Motivation

While working on #2183421: In InOperator Rename Views properties to core standards, I noticed that a local variable has an extra "s": $permisssion_by_module.

Proposed resolution

Remove the extra "s". Good place to try PhpStorm's Refactor function.

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#1 var_correction-2346215-1.patch1.22 KBupchuk

Comments

upchuk’s picture

upchuk commented
Assigned: Unassigned » upchuk
Status: Active » Needs review
StatusFileSize
new var_correction-2346215-1.patch1.22 KB

Here's a patch correcting the variable names in the test.

cilefen’s picture

cilefen commented
Status: Needs review » Reviewed & tested by the community

This looks just fine to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch. :)

Committed and pushed to 8.x. Thanks!

  • webchick committed 07736b1 on 8.0.x 
    Issue #2346215 by Upchuk | alimac: In HandlerFilterPermissionTest fix...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.