Developed patch upgrading fbconnect to use Facebook PHP SDK v4.0.11. Could you review it?

CommentFileSizeAuthor
#11 2345383-fbconnect-fb-sdk-4.1-with-tests.patch44.06 KBid.tarzanych
#10 2345383-fbconnect-fb-sdk-4.1-with-tests.patch41.75 KBid.tarzanych
#8 2345383-fbconnect-fb-sdk-41.patch32.75 KBid.tarzanych
#7 2345383-fbconnect-fb-sdk-41.patch32.86 KBid.tarzanych
#5 2345383-fbconnect-fb-sdk-41.patch32.75 KBid.tarzanych
fbconnect_upgrade_to_sdk_4.0.11.patch32.23 KBid.tarzanych
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

id.tarzanych’s picture

id.tarzanych CreditAttribution: id.tarzanych commented
Title: Upgraded to PHP SDK v4.0.11 » Upgrade patch to PHP SDK v4.0.11
Related issues: -#2311079: Migrate to Facebook PHP SDK 4
gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
CreditAttribution: gobinathm commented

Reviewing it .. will update soon

Whitou’s picture

Whitou CreditAttribution: Whitou commented

Any news around here ?

Yorgg’s picture

Yorgg CreditAttribution: Yorgg commented

I can't go to app settings on admin/config/people/fbconnect/fb-app
after setting keys: "Ensure that you entered valid api keys"

EDIT; I can also see the test got postponed.

id.tarzanych’s picture

id.tarzanych CreditAttribution: id.tarzanych commented
FileSize
2345383-fbconnect-fb-sdk-41.patch32.75 KB

Upgraded patch to make FBConnect use Facebook PHP SDK 4.1

id.tarzanych’s picture

id.tarzanych CreditAttribution: id.tarzanych commented
Title: Upgrade patch to PHP SDK v4.0.11 » Upgrade patch to PHP SDK v4.1.0-dev
id.tarzanych’s picture

id.tarzanych CreditAttribution: id.tarzanych commented
FileSize
2345383-fbconnect-fb-sdk-41.patch32.86 KB

Fixed namespace select bug in install file that caused requirements error

id.tarzanych’s picture

id.tarzanych CreditAttribution: id.tarzanych commented
FileSize
2345383-fbconnect-fb-sdk-41.patch32.75 KB

Fixed 'email' data-scope attribute for FB login button

Status: Needs review » Needs work

The last submitted patch, 8: 2345383-fbconnect-fb-sdk-41.patch, failed testing.

id.tarzanych’s picture

id.tarzanych CreditAttribution: id.tarzanych commented
Status: Needs work » Needs review
FileSize
2345383-fbconnect-fb-sdk-4.1-with-tests.patch41.75 KB

Fixed hook_rules_event_info() structure.
Fixed automated tests (however they it may not pass here because test requires Facebook application id and secret)

id.tarzanych’s picture

id.tarzanych CreditAttribution: id.tarzanych commented
FileSize
2345383-fbconnect-fb-sdk-4.1-with-tests.patch44.06 KB

Made code clean-up, fixed Exception classes, modified README.txt and fbconnect.make files

id.tarzanych’s picture

id.tarzanych CreditAttribution: id.tarzanych commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.