Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
Framework
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Sep 2014 at 06:58 UTC
Updated:
7 Apr 2017 at 09:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
drunken monkeyComment #2
alan-ps commentedI will look at this!
Comment #3
alan-ps commentedThis is a patch. It would be great to hear your thoughts about it. We, probably, should not show "Index details per datasource" if our index is not multiple, but I'm not sure: https://www.drupal.org/files/issues/details-per-datasource.png
Comment #4
drunken monkeyGood job, thanks!
However, even though this is exactly as I described it in the IS, I have some suggested improvements:
<small>tags so it doesn't draw too much attention.)TrackerPerDatasourceInterface. Then just check whether the tracker implements that before using it (and otherwise just don't provide this information).(Also, the first sentence in a doc comment should be only one line (max. 80 characters), so maybe just lose the "for this index" part for the two new methods' comments?)
Otherwise, though, this really looks very good already, so thanks again!
Comment #5
alan-ps commentedThanks for your response. I will continue work with it!
Comment #6
alan-ps commentedThis is a new patch for reviewing!
Comment #7
alan-ps commentedSorry, I forgot about untracked files( This is a correct patch.
Comment #8
drunken monkeySorry, should have reviewed more carefully: apparently (maybe at some point since I created this issue)
getIndexedItemsCount()et al. already have$datasource_idarguments, there doesn't seem to be any need for additional methods, an additional interface and all that jazz.Just a few lines in the theme function.
See the attached patch, and please test! (I don't have any web server running currently, so this is completely untested.)
And sorry for the confusion and unnecessary work!
Comment #9
alan-ps commentedyep, your code looks better. I can confirm that it works fine:
https://www.drupal.org/files/issues/datasource-details-v3.png
Comment #10
borisson_RTBC++
Comment #12
drunken monkeyGood to hear, thanks for reviewing!
Committed.
Thanks again for your work on this, alan-ps!