On a site running v7.x-2.9, when a page is loaded the "stLight" variable is undefined but the JS for checking this fact results in errors in IE8:
'stLight' is undefined

CommentFileSizeAuthor
#1 sharethis-n2339561-1.patch505 bytesDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Active » Needs review
FileSize
sharethis-n2339561-1.patch505 bytes

This appears to resolve the problem.

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Title: JS error in IE8 » JS error in IE8 & Firefox
Status: Needs review » Reviewed & tested by the community

Yes, that was introduced in #1845134: If JS from ShareThis does not load (due to adblocker or server failure), do not break other JS on the page and breaks Firefox with an adblocker.

New fix is correct :)

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Version: 7.x-2.9 » 7.x-2.x-dev
purushotam.rai’s picture

purushotam.rai CreditAttribution: purushotam.rai at QED42 commented
Issue tags: +Quickfix

purushotam.rai’s picture

purushotam.rai CreditAttribution: purushotam.rai at QED42 commented
Status: Reviewed & tested by the community » Fixed

Marking this issue as fixed. Thanks a lot for all your efforts.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.