This module provides two different permissions for allowing users to add twitter accounts.

1. Add Twitter accounts (which I'm assuming means unauthenticated accounts)
2. Add authenticated Twitter accounts

I have no use for unauthenticated twitter accounts on my site because users are only adding twitter accounts in order to automatically post content from their accounts. For this reason I've set permissions to allow all users to ADD AUTHENTICATED TWITTER ACCOUNTS while disabling the permission for all roles to ADD TWITTER ACCOUNTS (once again assuming this means unauthenticated accounts). However, all users have access to add both AUTHENTICATED and NON-AUTHENTICATED twitter accounts which has led to a lot of confusion and half of our users adding accounts the wrong way. There seems to be a bug that gives permissions for both options even when permission is only given to add AUTHENTICATED TWITTER ACCOUNTS is given.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

durum’s picture

Version: 7.x-5.8 » 7.x-5.x-dev
Status: Active » Needs review
FileSize
538 bytes

The patch fixes the issue.
IMHO twitter_connect() function is called by mistake instead of user_access('add twitter accounts') there, so this fixes it for the moment.

DamienMcKenna’s picture

DamienMcKenna’s picture

DamienMcKenna’s picture

Version: 7.x-5.x-dev » 6.x-5.x-dev
FileSize
566 bytes

The patch in #1 works for both the 7.x-5.x and 7.x-6.x branches, this one is for the 6.x-5.x branch.

DamienMcKenna’s picture

Status: Needs review » Fixed

Committed. Thanks durum!

  • DamienMcKenna committed a8854fe on 7.x-5.x authored by durum
    Issue #2338125 by durum: Fixed permission check for adding non-...

  • DamienMcKenna committed d59f897 on 7.x-6.x authored by durum
    Issue #2338125 by durum: Fixed permission check for adding non-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.