The issue is if you start with a device on portrait then rotate to landscape the backdrop will resize to the landscape's width. On rotating back to portrait the backdrop retains the landscape width thus pushing the document size to be the same as landscape.

CommentFileSizeAuthor
#9 2337691-ctools-backdrop-orientation-size-9.patch935 bytesmrjmd
#5 2337691-ctools-backdrop-orientation-size-2.patch500 bytesjerrylow
#4 2337691-ctools-backdrop-orientation-size-1.patch616 bytesjerrylow
#1 2337691-ctools-backdrop-orientation-size.patch688 bytesjerrylow

Comments

jerrylow’s picture

jerrylow commented
StatusFileSize
new 2337691-ctools-backdrop-orientation-size.patch688 bytes
fabianx’s picture

fabianx commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: 2337691-ctools-backdrop-orientation-size.patch, failed testing.

jerrylow’s picture

jerrylow commented
StatusFileSize
new 2337691-ctools-backdrop-orientation-size-1.patch616 bytes

Wrong path.

jerrylow’s picture

jerrylow commented
StatusFileSize
new 2337691-ctools-backdrop-orientation-size-2.patch500 bytes

That was still off. Here's the corrected path and changed the jQuery code to match the coding styles of modal.js.

fabianx’s picture

fabianx commented
Status: Needs work » Needs review

DamienMcKenna queued 5: 2337691-ctools-backdrop-orientation-size-2.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: 2337691-ctools-backdrop-orientation-size-2.patch, failed testing.

mrjmd’s picture

mrjmd commented
Status: Needs work » Needs review
StatusFileSize
new 2337691-ctools-backdrop-orientation-size-9.patch935 bytes

Re-rolled and fixed some coding standard issues.

fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

RTBC, looks great.

  • japerry committed cb3f55f on 7.x-1.x authored by mrjmd 
    Issue #2337691 by jerrylow, mrjmd: Modal backdrop size is inaccurate on...
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Yup, fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.