Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in /modules/fivestar/fivestar.module on line 1336

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in /modules/fivestar/fivestar.module on line 1340

Files: 

Comments

Mark Theunissen’s picture

Priority:Minor» Normal
StatusFileSize
new1.27 KB

Just got this error too, it's got to do with the 3 new functions introduced in this version.

e.g.

<?php
function fivestar_views_widget_normal_handler($op, $filter, $value, &$query) {
?>

Passing &$query by reference is causing the problem. Since it's not altered in fivestar_views_widget_handler(), I changed it to be pass-by-value in all the cases it's called.

See patch.

mgifford’s picture

thanks, seemed to work for me.

quicksketch’s picture

Status:Active» Fixed
StatusFileSize
new848 bytes

Thanks, the patch was a bit excessive as it removed referenced variables that weren't call-time references. I've applied the attached patch to CVS. Thanks!

Anonymous’s picture

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

A_Screamer’s picture

Status:Closed (fixed)» Postponed (maintainer needs more info)

Any chance of getting this patch integrated into the 5.x release for this one?

quicksketch’s picture

Status:Postponed (maintainer needs more info)» Fixed

This is already integrated into both 6.x and 5.x. It'll be in the 1.12 release.

A_Screamer’s picture

Hi quicksketch,

I only see version 1.11 on the download page. Where can I download version 1.12?

Thanks in advance...

quicksketch’s picture

1.12 isn't out yet, but the bug has already been fixed. If you need to temporarily fix the problem you can download the development version http://drupal.org/node/192517 until 1.12 is released.

quicksketch’s picture

Marked http://drupal.org/node/246038 as duplicate.

Anonymous’s picture

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

hariram_sharma’s picture

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/content/h/i/d/hidelhi/html/websites/mank/humannetwork/sites/all/modules/fivestar/fivestar.module on line 1336