// DBTNG doesn't support to add the same subquery twice to the main
          // query and the count query, so clone the subquery to have two instances
          // of the same object. - http://drupal.org/node/1112854
          if (is_object($clause['value']) && $clause['value'] instanceof SelectQuery) {
            $clause['value'] = clone $clause['value'];
          }

The instance of here can never be true because there is no use statement for SelectQuery. Therefore either this code is not needed or we are missing test coverage.

CommentFileSizeAuthor
d8.views-missing-select-query.patch1.01 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Oh wow that other issues is ages ago!

  • webchick committed 2160645 on 8.0.x
    Issue #2337619 by alexpott: Fixed Drupal\views\Plugin\views\query\Sql::...
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.