Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
// DBTNG doesn't support to add the same subquery twice to the main
// query and the count query, so clone the subquery to have two instances
// of the same object. - http://drupal.org/node/1112854
if (is_object($clause['value']) && $clause['value'] instanceof SelectQuery) {
$clause['value'] = clone $clause['value'];
}
The instance of here can never be true because there is no use statement for SelectQuery. Therefore either this code is not needed or we are missing test coverage.
Comment | File | Size | Author |
---|---|---|---|
d8.views-missing-select-query.patch | 1.01 KB | alexpott | |
Comments
Comment #1
dawehnerOh wow that other issues is ages ago!
Comment #3
webchickCommitted and pushed to 8.x. Thanks!