Problem/Motivation

If you work with features and your developers have different environments (Win / *nix) the exported configuration might contain \r\n or \n as line break.
PHP_EOL always uses the system style of line breaks. So if someone exported the feature with Unix, which uses \n only, explode(PHP_EOL, $titles) won't work on Windows because it's looking for \r\n.

Proposed resolution

Simply split by \n - the time() will get rid of the \r.

Remaining tasks

Reviews needed.

User interface changes

none

API changes

none

CommentFileSizeAuthor
panels_breadcrumbs-do-not-use-PHP_EOL.patch810 bytesdas-peter

Comments

Jorrit’s picture

Jorrit commented
Status: Needs review » Reviewed & tested by the community

This is an excellent suggestion. One typo in the post: trim() gets rid of the \r.

IreneV’s picture

IreneV commented

Will be added in next release

  • IreneV committed c2a440f on 7.x-2.x 
    Issue #2337529 by das-peter, Jorrit, IreneV: Do not use PHP_EOL to split...
IreneV’s picture

IreneV commented
Status: Reviewed & tested by the community » Fixed
IreneV’s picture

IreneV commented
Status: Fixed » Closed (fixed)