Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The namespace declaration of Drupal\migrate_drupal\Plugin\migrate\process\d6\UserPicture
reads:
namespace Drupal\migrate_drupal\Plugin\migrate\Process\d6;
Proposed resolution
It should read:
namespace Drupal\migrate_drupal\Plugin\migrate\process\d6;
See the file core/modules/migrate_drupal/src/Plugin/migrate/process/d6/UserPicture.php
.
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff.txt | 1.13 KB | benjy |
#7 | 2336285-7.patch | 13.64 KB | benjy |
#6 | d8-namespace_typo-2336285-6.patch | 12.51 KB | er.pushpinderrana |
#2 | d8-namespace_typo-2336285-2.patch | 677 bytes | astrocling |
Comments
Comment #1
astrocling CreditAttribution: astrocling commentedI will work on it now.
Comment #2
astrocling CreditAttribution: astrocling commentedHere is the change correcting the typo.
Comment #3
tstoecklerWow, that was quick! :-) Thanks, looks great.
Comment #4
tstoecklerYeah.... meant to RTBC...
Comment #5
alexpottLet's fix all the instances of
Drupal\migrate_drupal\Plugin\migrate\Process
in both namespaces and @file doc blocks.Comment #6
er.pushpinderrana CreditAttribution: er.pushpinderrana commentedPlease review updated patch.
Comment #7
benjy CreditAttribution: benjy commentedGrep showed two more instances, fixed them in comments.
RTBC for me but i'll let someone else do it since I just posted this patch.
Comment #8
leslieg CreditAttribution: leslieg commentedComment #9
chx CreditAttribution: chx commentedFrom http://the-echoplex.net/log/php-case-sensitivity
Case sensitive (both user defined and PHP defined)
Case insensitive (both user defined and PHP defined)
I love PHP. Absolutely. Class properties are case sensitive but methods are not.
Anyways, this is good to go.
Comment #10
leslieg CreditAttribution: leslieg commentedSkipProcessOnEmpty is being called instead of FlagSkipProcess. Was a change to the process intended or was it just a change from Process to process?
Comment #11
leslieg CreditAttribution: leslieg commentedComment #12
benjy CreditAttribution: benjy commentedThat's not a mistake, that's a fix for an incorrect class name at the same time as fixing "Process"
Comment #13
alexpottCommitted f1fa0c8 and pushed to 8.0.x. Thanks!