Problem/Motivation

The namespace declaration of Drupal\migrate_drupal\Plugin\migrate\process\d6\UserPicture reads:

namespace Drupal\migrate_drupal\Plugin\migrate\Process\d6;

Proposed resolution

It should read:

namespace Drupal\migrate_drupal\Plugin\migrate\process\d6;

See the file core/modules/migrate_drupal/src/Plugin/migrate/process/d6/UserPicture.php.

Remaining tasks

User interface changes

API changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

astrocling’s picture

Assigned: Unassigned » astrocling

I will work on it now.

astrocling’s picture

Assigned: astrocling » Unassigned
Status: Active » Needs review
FileSize
677 bytes

Here is the change correcting the typo.

tstoeckler’s picture

Wow, that was quick! :-) Thanks, looks great.

tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

Yeah.... meant to RTBC...

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Let's fix all the instances of Drupal\migrate_drupal\Plugin\migrate\Process in both namespaces and @file doc blocks.

er.pushpinderrana’s picture

Status: Needs work » Needs review
FileSize
12.51 KB

Please review updated patch.

benjy’s picture

FileSize
13.64 KB
1.13 KB

Grep showed two more instances, fixed them in comments.

grep -rn "migrate\\\\Process\\\\" core/modules/migrate
grep -rn "migrate\\\\Process\\\\" core/modules/migrate_drupal

RTBC for me but i'll let someone else do it since I just posted this patch.

leslieg’s picture

Assigned: Unassigned » leslieg
chx’s picture

Status: Needs review » Reviewed & tested by the community

From http://the-echoplex.net/log/php-case-sensitivity

Case sensitive (both user defined and PHP defined)

  • variables
  • constants
  • array keys
  • class properties
  • class constants

Case insensitive (both user defined and PHP defined)

  • functions
  • class constructors
  • class methods
  • keywords and constructs (if, else, null, foreach, echo etc.)

I love PHP. Absolutely. Class properties are case sensitive but methods are not.

Anyways, this is good to go.

leslieg’s picture

Status: Reviewed & tested by the community » Needs work

SkipProcessOnEmpty is being called instead of FlagSkipProcess. Was a change to the process intended or was it just a change from Process to process?

- * Contains \Drupal\migrate\Plugin\migrate\Process\d6\FlagSkipProcess.
+ * Contains \Drupal\migrate\Plugin\migrate\process\d6\SkipProcessOnEmpty.
leslieg’s picture

Assigned: leslieg » Unassigned
benjy’s picture

Status: Needs work » Reviewed & tested by the community

There is a mistake in line 6 of the migrate module. SkipProcessOnEmpty is
being called instead of FlagSkipProcess

That's not a mistake, that's a fix for an incorrect class name at the same time as fixing "Process"

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed f1fa0c8 and pushed to 8.0.x. Thanks!

  • alexpott committed f1fa0c8 on 8.0.x
    Issue #2336285 by benjy, er.pushpinderrana, astrocling | tstoeckler:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.