This applies to supportsIndex() method in CommerceSearchApiAlterProductStatus and CommerceSearchApiProductDisplayFilter - when checking for supported entity types, it should use $index->getEntityType() instead of $index->item_type, as these do not have to be the same.

Example: multilingual indexes provided by Search API Entity Translation, where for multilingual node indexes item_type equals search_api_et_node.

Patch to follow.

CommentFileSizeAuthor
#1 commerce_search_api-entity_type_check-2335137-1.patch1.19 KBmaciej.zgadzaj
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

maciej.zgadzaj’s picture

maciej.zgadzaj CreditAttribution: maciej.zgadzaj commented
Status: Active » Needs review
FileSize
commerce_search_api-entity_type_check-2335137-1.patch1.19 KB
jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented

I just gave you the commit access, feel free to commit it :).

maciej.zgadzaj’s picture

maciej.zgadzaj CreditAttribution: maciej.zgadzaj commented
Status: Needs review » Fixed

Thanks, and done!

  • maciej.zgadzaj committed 6306daa on 7.x-1.x 
    Issue #2335137: Use proper entity type check in data alteration classes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.