Problem/Motivation
The hover state of the dropbutton is overflowing the box' border.

Proposed resolution
CSS fix in dropbutton.component.css --> border-radius: 0.9em to 1em.
Remaining tasks
None
User interface changes
- Before

- After

API changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | Screen Shot 2016-02-26 at 17.52.48.png | 16.89 KB | emma.maria |
| #16 | Screen Shot 2016-02-26 at 17.52.42.png | 21.89 KB | emma.maria |
| #15 | open_hoverstate-2334363-15.patch | 1.4 KB | nesta_ |
| #15 | interdiff-2334363-13-15.txt | 461 bytes | nesta_ |
| #13 | 2334363-hoverstate-dropdownbutton-10863680-8.patch | 1.43 KB | Sumit kumar |
Comments
Comment #1
yvesvanlaer commentedComment #2
alansaviolobo commentedpatch still applies.
Comment #3
lewisnymanLooks like a Seven issue
Comment #4
idebr commented@yvesvanlaer Thanks for submitting this bug report! The solution is correct, but the implementation can be more fool proof by removing css (!). The value for the border-radius doesn't actually matter as long as it is big, so it can be 1em or 20em; the display will be the same. For example, the base implementation for the dropbutton is:
The code that is causing the overflow was added to remove the corners from an open dropbutton. The same effect can be achieved by settings
border-bottom-left-radius: 0;. This bypasses the value problem altogether. As a result, various places where a value is added can be removed.@LewisNyman Views UI has the same problem and took a similar approach to fixing it, so this touches views CSS as well. From /modules/views_ui/css/views_ui.admin.theme.css:
Comment #5
idebr commentedComment #6
joginderpcComment #7
idebr commented@joginderpc Thanks for picking this up!
This is the opposite of what I suggested in #4. Please have a look at #4 for the suggested approach.
Are these changes necessary? They seem out of scope for this issue.
Comment #8
joginderpccheck for next file.
Comment #9
mgiffordNeeds re-roll.
Comment #10
nesta_ commentedI try to make a re-roll but the console show --> fatal: unrecognized input.
Change status to need review for re-test
Comment #11
mgiffordLet's try just re-uploading the patch for the bots.
Comment #13
Sumit kumar commentedadding patch for this
Comment #14
Sumit kumar commentedComment #15
nesta_ commentedI added a newline at end of file.
Comment #16
emma.mariaI have manually tested Seven without any patches applied and I can no longer replicate the issue.
See screenshot below of open dropbutton being hovered over...
Please feel free to reopen if you still find the issue.