Problem/Motivation

The hover state of the dropbutton is overflowing the box' border.

Proposed resolution

CSS fix in dropbutton.component.css --> border-radius: 0.9em to 1em.

Remaining tasks

None

User interface changes

Before
After

API changes

None

Comments

yvesvanlaer’s picture

Status: Active » Needs review
StatusFileSize
new1.31 KB
alansaviolobo’s picture

patch still applies.

lewisnyman’s picture

Component: CSS » Seven theme
Issue tags: -DUGBE1409 +frontend

Looks like a Seven issue

idebr’s picture

Component: Seven theme » CSS
Status: Needs review » Needs work

@yvesvanlaer Thanks for submitting this bug report! The solution is correct, but the implementation can be more fool proof by removing css (!). The value for the border-radius doesn't actually matter as long as it is big, so it can be 1em or 20em; the display will be the same. For example, the base implementation for the dropbutton is:

.js .dropbutton-widget .dropbutton-action a {
  border-radius: 20em 0 0 20em;
  padding: 4px 1.5em;
  display: block;
  width: 100%;
}

The code that is causing the overflow was added to remove the corners from an open dropbutton. The same effect can be achieved by settings border-bottom-left-radius: 0;. This bypasses the value problem altogether. As a result, various places where a value is added can be removed.

@LewisNyman Views UI has the same problem and took a similar approach to fixing it, so this touches views CSS as well. From /modules/views_ui/css/views_ui.admin.theme.css:

.js .dropbutton-wrapper.dropbutton-multiple.open .dropbutton-action:first-child a {
  border-radius: 1.1em 0 0 0; /* LTR */
}
[dir="rtl"].js .dropbutton-wrapper.dropbutton-multiple.open .dropbutton-action:first-child a {
  border-radius: 0 1.1em 0 0;
}
.js .dropbutton-wrapper.dropbutton-multiple.open .dropbutton-action:last-child a {
  border-radius: 0 0 0 1.1em; /* LTR */
}
[dir="rtl"].js .dropbutton-wrapper.dropbutton-multiple.open .dropbutton-action:last-child a {
  border-radius: 0 0 1.1em 0;
}
idebr’s picture

joginderpc’s picture

Assigned: yvesvanlaer » joginderpc
Status: Needs work » Needs review
Issue tags: +SprintWeekend2015
StatusFileSize
new3.76 KB
idebr’s picture

Status: Needs review » Needs work

@joginderpc Thanks for picking this up!

  1. +++ b/core/themes/seven/css/components/dropbutton.component.css
    @@ -87,10 +87,13 @@
    -  border-radius: 20em 0 0 20em; /* LTR */
    +  border-radius: 1em 0 0 1em; /* LTR */
    

    This is the opposite of what I suggested in #4. Please have a look at #4 for the suggested approach.

  2. +++ b/core/themes/seven/css/components/dropbutton.component.css
    @@ -87,10 +87,13 @@
    +  border-top: 1px solid #a6a6a6;
    +  border-left: 1px solid #a6a6a6;
    +  border-right: 1px solid #a6a6a6;
    

    Are these changes necessary? They seem out of scope for this issue.

joginderpc’s picture

Status: Needs work » Needs review
StatusFileSize
new3.3 KB

check for next file.

mgifford’s picture

Status: Needs review » Needs work

Needs re-roll.

nesta_’s picture

Status: Needs work » Needs review

I try to make a re-roll but the console show --> fatal: unrecognized input.

Change status to need review for re-test

mgifford’s picture

StatusFileSize
new3.3 KB

Let's try just re-uploading the patch for the bots.

Status: Needs review » Needs work

The last submitted patch, 11: 2334363-hoverstate-dropbutton-6_1.patch, failed testing.

Sumit kumar’s picture

Status: Needs work » Needs review
StatusFileSize
new1.43 KB

adding patch for this

Sumit kumar’s picture

Issue tags: +drupalconasia2016
nesta_’s picture

StatusFileSize
new461 bytes
new1.4 KB
+++ b/core/themes/seven/css/components/dropbutton.component.css
@@ -319,3 +319,9 @@
+ .js .dropbutton-multiple.open .dropbutton-action:last-child:hover a  {
+    border-radius: 0px 0px 0px 1em;
+ }
\ No newline at end of file
 

I added a newline at end of file.

emma.maria’s picture

Component: CSS » Seven theme
Assigned: joginderpc » Unassigned
Issue summary: View changes
Status: Needs review » Closed (cannot reproduce)
StatusFileSize
new21.89 KB
new16.89 KB

I have manually tested Seven without any patches applied and I can no longer replicate the issue.

See screenshot below of open dropbutton being hovered over...

Please feel free to reopen if you still find the issue.