Closed (fixed)
Project:
Feeds
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Sep 2014 at 18:33 UTC
Updated:
25 Apr 2015 at 06:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
megachrizUpdated issue summary.
Comment #2
megachrizIt appears to be that the argument in the path "/import/%/log" is already validated. This happens in views/feeds_views_handler_argument_importer_id.inc. It is that only the wrong action is taken when the argument is not valid. It should be "Show page not found" and not "Display contents of no result found".
A validator for "/node/%/log" indeed is needed. Now a "Log" tab shows up for every node, even when that node is not a feed node.
The attached patch does the following:
Side node: the Log view could be improved more. See #1393898: Order Log view by flid instead of log_time.
Comment #4
twistor commentedAwesome!
We could probably add some configuration options for importer type to the feed node validator at some point, but this looks great.
Comment #5
twistor commented@MegaChriz, I've uploaded a patch for #1393898: Order Log view by flid instead of log_time. Simple enough. How did you get the translatables export?
Comment #6
megachrizAwesome work on Feeds, twistor!
Because I see these translatables always when I export a View, I thought they were added by default. Further exploration learns me that they are only exported when the core module "Locale" is enabled (or when Views' localization plugin gets overridden, see below), which I have enabled by default because I usually install my sites in Dutch.
From views/includes/view.inc, method
export(), ± line 1917:Views uses its localization plugin to export translatables.
From views/views.module, ± line 1351:
The localization plugin can be overridden.