Hi.

I have a suggestion to your already excellent module:

When you throw many log messages in short time, there's a big chance of getting messages with the same date/time. As a result, messages doesn't show properly in the Log view.

I would suggest ordering the view by flid field (and maybe also by log_time), that will show log items in the correct order. Also, it would be nice to add the "Sortable" attribute to view columns.

Regards and thank you very much for this remarkable piece of code.

CommentFileSizeAuthor
#5 interdiff-1393898-1-5.txt867 bytesmegachriz
#5 feeds-sort-log-by-id-1393898-5.patch2.23 KBmegachriz
#1 feeds-sort-log-by-id-1393898-1.patch2.16 KBtwistor

Comments

twistor’s picture

twistor commented
Version: 7.x-2.0-alpha4 » 7.x-2.x-dev
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new feeds-sort-log-by-id-1393898-1.patch2.16 KB

This should do it.

Status: Needs review » Needs work

The last submitted patch, 1: feeds-sort-log-by-id-1393898-1.patch, failed testing.

Status: Needs work » Needs review

MegaChriz queued 1: feeds-sort-log-by-id-1393898-1.patch for re-testing.

twistor queued 1: feeds-sort-log-by-id-1393898-1.patch for re-testing.

megachriz’s picture

megachriz
Primary language Dutch
commented
Related issues: +#2530670: Filter log in Views by "Message"
StatusFileSize
new feeds-sort-log-by-id-1393898-5.patch2.23 KB
new interdiff-1393898-1-5.txt867 bytes

The patch from #1 works fine. In the attached patch I complemented the column "flid" with "filter" and "argument". I also removed the code comments as these are only useful to understand Views, so these would belong in Views, not Feeds.

  • MegaChriz committed aafeae0 on 7.x-2.x authored by twistor 
    Issue #1393898 by MegaChriz, twistor: Order Log view by flid instead of...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Committed #5.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.