PHPStorm tells me this function is not called anymore. Let's see if it's right. If so, yay!

CommentFileSizeAuthor
#8 interdiff.txt1.36 KBkgoel
#8 remove-drupal-render-page-2332551-8.patch2.93 KBkgoel
#3 remove-drupal_render_page-2332551-3.patch2.87 KBpushpinderchauhan
remove-drupal_render_page.patch2.28 KBCrell

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

I'm seeing one more reference in common.inc line 2944 in a comment

fabianx’s picture

fabianx commented
Status: Needs review » Needs work

as per #1

pushpinderchauhan’s picture

pushpinderchauhan commented
Status: Needs work » Needs review
StatusFileSize
new remove-drupal_render_page-2332551-3.patch2.87 KB

Update patch as per #1.

lostkangaroo’s picture

lostkangaroo commented
Status: Needs review » Reviewed & tested by the community

Just ran this through and couldn't find any traces of drupal_render_page() after the patch.

Crell’s picture

Crell commented
Issue tags: +Quick fix
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record 
+++ b/core/includes/theme.inc
@@ -1812,8 +1812,6 @@ function template_preprocess_html(&$variables) {
- * @see drupal_render_page()

+++ b/core/modules/system/system.api.php
@@ -375,7 +375,6 @@ function hook_ajax_render_alter(array &$data) {
- * @see drupal_render_page()

@@ -660,7 +659,6 @@ function hook_contextual_links_plugins_alter(array &$contextual_links) {
- * @see drupal_render_page()

How about replacing these with a reference to DefaultHtmlFragmentRenderer::render()?

Also we should at least reference (or write) the change record that made drupal_render_page() obsolete.

kgoel’s picture

kgoel commented

working on reroll and change record.

kgoel’s picture

kgoel commented
Status: Needs work » Needs review
StatusFileSize
new remove-drupal-render-page-2332551-8.patch2.93 KB
new interdiff.txt1.36 KB
kgoel’s picture

kgoel commented

Added change record - https://www.drupal.org/node/2337551

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs change record

Tweaked change record, we're done.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 7f69cb4 and pushed to 8.0.x. Thanks!

  • alexpott committed 7f69cb4 on 8.0.x 
    Issue #2332551 by kgoel, er.pushpinderrana, Crell: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.