[D7] Quick Views Display List [#2331047]

Project description and development by hwi2

The Quick Views Display List is a quick and dirty list of all views and their associated displays. It is beneficial to views that have many displays. Each view hyperlink links to the parent view page and each display hyperlink links to its tab so editing of the display can be further edited.

Sometimes, getting to the exact display takes between 3 to 5 clicks, so this module was created to simplify the number of clicks and access the exact display you need. Also, for long display names, the tabs are usually cut off, so this list is great for that purpose.

Sandbox Page: https://www.drupal.org/sandbox/hwi2/2330527
GIT: https://git.drupal.org:sandbox/hwi2/2330527.git

For Views In Code

The module will not only find views in the database, but also views that are exported to code. In order coded views to be listed, the code must reside in an external file with "VIEW_NAME.views_default.inc", which is the standard way of using exported views. The view must also implement hook_views_api() in a module related to each coded view.

Available As A Page Or Block

For troubleshooting purposes during development of any Drupal website, a block is also available, but for better security, the list can be accessed in the Development section of the Configuration page.

Required Modules

Views

Reviews of other projects

Taxonomy Tracking Module: https://www.drupal.org/comment/9120251/
GPA Calculator: https://www.drupal.org/node/2315327#comment-9120359
Image Style Mapping: https://www.drupal.org/node/2323567#comment-9120465
Document Library: https://www.drupal.org/node/2320783#comment-9120693
Page Background: https://www.drupal.org/node/2238015#comment-9122361

Comment	File	Size	Author
#14	quick_views_errors.txt	14.61 KB	rob.barnett

Comments

Comment #1

shrop commented 1 September 2014 at 20:15

I ran dursh coder on this module and there are a number of fixes that need to be made. Many of the changes are related to tab/specing issues. This needs to be fixed up before recommending the sandbox owner to have access to create full projects.

Here are some recommendations:

Read and learn: Drupal Coding Stanards
Not sure what editor or IDE you use, but there are docs around on who to setup to get your tabs/specs to follow the coding standards above. Let me know and I can help find the info if needed.
Installed Coder and setup with Drush so you can run coding standard checks against your code. Instructions

Coder findings can be seen below. Please fix and let me know. I can continue code review from there.

$ drush coder --no-empty --minor --comment --i18n --security --sql --style --druplart --sniffer --ignorename quick_views_display_list.*
Severity minor, Drupal Commenting Standards, Drupl'Art Coding Style, Internationalization, Drupal Security Checks, Drupal CodeSniffer, Drupal SQL Standards, Drupal Coding Standards

/Users/shrop/Projects/Community/quick_views_display_list/quick_views_display_list.css:
 +2: [sniffer_squiz_css_emptyclassdefinition_found, minor] Class definition is empty
 +3: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +3: [style_trailing_spaces, minor] There should be no trailing spaces
 +8: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +8: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +9: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +9: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +9: [sniffer_squiz_whitespace_superfluouswhitespace_endline, minor] Whitespace found at end of line
 +9: [style_trailing_spaces, minor] There should be no trailing spaces
 +10: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +10: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +10: [sniffer_squiz_whitespace_superfluouswhitespace_endline, minor] Whitespace found at end of line
 +10: [style_trailing_spaces, minor] There should be no trailing spaces
 +11: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +11: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +16: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +16: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +16: [sniffer_squiz_whitespace_superfluouswhitespace_endline, minor] Whitespace found at end of line
 +16: [style_trailing_spaces, minor] There should be no trailing spaces
 +17: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +17: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +17: [sniffer_squiz_whitespace_superfluouswhitespace_endline, minor] Whitespace found at end of line
 +17: [style_trailing_spaces, minor] There should be no trailing spaces
 +18: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +18: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +18: [sniffer_squiz_whitespace_superfluouswhitespace_endline, minor] Whitespace found at end of line
 +18: [style_trailing_spaces, minor] There should be no trailing spaces
 +19: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +19: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +24: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +24: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +25: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +25: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +26: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +26: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +31: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +31: [sniffer_squiz_css_disallowmultiplestyledefinitions_found, minor] Each style definition must be on a line by itself
 +31: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +31: [sniffer_squiz_css_disallowmultiplestyledefinitions_found, minor] Each style definition must be on a line by itself
 +31: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +31: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +36: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +36: [sniffer_squiz_css_disallowmultiplestyledefinitions_found, minor] Each style definition must be on a line by itself
 +36: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +36: [sniffer_squiz_css_disallowmultiplestyledefinitions_found, minor] Each style definition must be on a line by itself
 +36: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +36: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +41: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +41: [sniffer_squiz_css_disallowmultiplestyledefinitions_found, minor] Each style definition must be on a line by itself
 +41: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +41: [sniffer_squiz_css_disallowmultiplestyledefinitions_found, minor] Each style definition must be on a line by itself
 +41: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +41: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +46: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +46: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +46: [sniffer_squiz_whitespace_superfluouswhitespace_endline, minor] Whitespace found at end of line
 +46: [style_trailing_spaces, minor] There should be no trailing spaces
 +47: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +47: [sniffer_squiz_css_colonspacing_noneafter, minor] Expected 1 space after colon in style definition; 0 found
 +49: [sniffer_squiz_whitespace_superfluouswhitespace_endfile, minor] Additional whitespace found at end of file

/Users/shrop/Projects/Community/quick_views_display_list/quick_views_display_list.module:
 File: [comment_docblock_file, normal] @file block missing
 +2: [sniffer_commenting_filecomment_missing, minor] Missing file doc comment
 +3: [comment_comment_docblock_missing, minor] Docblock should be immediately above quick_views_display_list_init
 +4: [sniffer_generic_functions_openingfunctionbracekernighanritchie_braceonnewline, minor] Opening brace should be on the same line as the declaration
 +4: [style_curly_braces, normal] curly braces { should end a line, not start one
 +5: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +5: [sniffer_controlstructures_controlsignature, minor] Expected "if (...) {\n"; found "if(...)\n\t{\n"
 +5: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +5: [sniffer_generic_php_uppercaseconstant_found, minor] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 +5: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +5: [style_control_spacing, normal] Control statements should have one space between the control keyword and opening parenthesis
 +5: [style_comma_spacing, normal] missing space after comma
 +5: [style_uppercase_constants, normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
 +6: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +6: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +6: [style_curly_braces, normal] curly braces { should end a line, not start one
 +7: [i18n_8, normal] The $message argument to drupal_set_message http://api.drupal.org/api/function/drupal_set_message/() should be enclosed within t http://api.drupal.org/api/function/t/() so that it is translatable.
 +7: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 4 spaces, found 2
 +7: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +7: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +8: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +8: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +12: [comment_comment_docblock_missing, minor] Docblock should be immediately above quick_views_display_list_help
 +13: [sniffer_generic_functions_openingfunctionbracekernighanritchie_braceonnewline, minor] Opening brace should be on the same line as the declaration
 +13: [style_curly_braces, normal] curly braces { should end a line, not start one
 +14: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +14: [sniffer_controlstructures_controlsignature, minor] Expected "switch (...) {\n"; found "switch(...)\n\t{\n"
 +14: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +14: [style_control_spacing, normal] Control statements should have one space between the control keyword and opening parenthesis
 +15: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +15: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +15: [style_curly_braces, normal] curly braces { should end a line, not start one
 +16: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +16: [sniffer_whitespace_scopeindent_incorrect, minor] Line indented incorrectly; expected 4 spaces, found 2
 +16: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +17: [sniffer_whitespace_scopeclosingbrace_breakident, minor] Case breaking statement indented incorrectly; expected 4 spaces, found 2
 +17: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +17: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +34: [style_trailing_spaces, minor] There should be no trailing spaces
 +39: [style_trailing_spaces, minor] There should be no trailing spaces
 +52: [sniffer_pear_functions_functioncallsignature_spaceafterclosebracket, minor] Space after closing parenthesis of function call prohibited
 +52: [sniffer_squiz_whitespace_semicolonspacing_incorrect, minor] Space found before semicolon; expected ");" but found ") ;"
 +53: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +53: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +56: [comment_comment_docblock_missing, minor] Docblock should be immediately above quick_views_display_list_admin_menu_output_build
 +57: [sniffer_generic_functions_openingfunctionbracekernighanritchie_braceonnewline, minor] Opening brace should be on the same line as the declaration
 +57: [style_curly_braces, normal] curly braces { should end a line, not start one
 +58: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 2 spaces, found 1
 +58: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +58: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +59: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +59: [sniffer_squiz_whitespace_superfluouswhitespace_endline, minor] Whitespace found at end of line
 +59: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +59: [style_trailing_spaces, minor] There should be no trailing spaces
 +60: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +60: [sniffer_squiz_whitespace_superfluouswhitespace_endline, minor] Whitespace found at end of line
 +60: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +60: [style_trailing_spaces, minor] There should be no trailing spaces
 +61: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +61: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +62: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +62: [sniffer_squiz_whitespace_superfluouswhitespace_endline, minor] Whitespace found at end of line
 +62: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +62: [style_trailing_spaces, minor] There should be no trailing spaces
 +65: [comment_comment_docblock_missing, minor] Docblock should be immediately above quick_views_display_list_block_info
 +67: [i18n_11, normal] The $string argument to t http://api.drupal.org/api/function/t/() should not begin or end with a space.
 +73: [comment_comment_docblock_missing, minor] Docblock should be immediately above quick_views_display_list_menu
 +76: [i18n_10, normal] Menu item titles and descriptions should NOT be enclosed within t http://api.drupal.org/api/function/t/().
 +76: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 2 spaces, found 1
 +76: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +76: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +77: [i18n_10, normal] Menu item titles and descriptions should NOT be enclosed within t http://api.drupal.org/api/function/t/().
 +77: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 2 spaces, found 1
 +77: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +77: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +78: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 2 spaces, found 1
 +78: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +78: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +79: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 2 spaces, found 1
 +79: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +79: [sniffer_squiz_whitespace_superfluouswhitespace_endline, minor] Whitespace found at end of line
 +79: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +79: [style_trailing_spaces, minor] There should be no trailing spaces
 +80: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 2 spaces, found 1
 +80: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +80: [sniffer_squiz_whitespace_superfluouswhitespace_endline, minor] Whitespace found at end of line
 +80: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +80: [style_comma_spacing, normal] missing space after comma
 +80: [style_trailing_spaces, minor] There should be no trailing spaces
 +88: [comment_comment_docblock_missing, minor] Docblock should be immediately above quick_views_display_list_block_view
 +90: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 2 spaces, found 1
 +90: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +90: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +91: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +91: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +91: [style_trailing_spaces, minor] There should be no trailing spaces
 +92: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +92: [sniffer_whitespace_scopeindent_incorrect, minor] Line indented incorrectly; expected 2 spaces, found 1
 +92: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +93: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +93: [sniffer_whitespace_scopeindent_incorrect, minor] Line indented incorrectly; expected 4 spaces, found 5
 +93: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +94: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 6 spaces, found 7
 +94: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +94: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +95: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 6 spaces, found 7
 +95: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +95: [sniffer_pear_functions_functioncallsignature_spaceafterclosebracket, minor] Space after closing parenthesis of function call prohibited
 +95: [sniffer_squiz_whitespace_semicolonspacing_incorrect, minor] Space found before semicolon; expected ");" but found ") ;"
 +95: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +96: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +96: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +97: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +97: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +99: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 2 spaces, found 3
 +99: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +99: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +105: [comment_comment_docblock_missing, minor] Docblock should be immediately above list_table
 +106: [sniffer_generic_functions_openingfunctionbracekernighanritchie_braceonnewline, minor] Opening brace should be on the same line as the declaration
 +106: [style_curly_braces, normal] curly braces { should end a line, not start one
 +108: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +108: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +109: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +109: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +110: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +110: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +112: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +112: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +113: [sniffer_squiz_whitespace_superfluouswhitespace_emptylines, minor] Functions must not contain multiple empty lines in a row; found 2 empty lines
 +115: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +115: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +116: [style_trailing_spaces, minor] There should be no trailing spaces
 +117: [style_trailing_spaces, minor] There should be no trailing spaces
 +118: [style_trailing_spaces, minor] There should be no trailing spaces
 +121: [sniffer_squiz_whitespace_superfluouswhitespace_emptylines, minor] Functions must not contain multiple empty lines in a row; found 2 empty lines
 +123: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +123: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +139: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +139: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +140: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 4 spaces, found 5
 +140: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +140: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +141: [style_trailing_spaces, minor] There should be no trailing spaces
 +142: [style_string_spacing, normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
 +143: [style_string_spacing, normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
 +144: [style_trailing_spaces, minor] There should be no trailing spaces
 +148: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 4 spaces, found 5
 +148: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +148: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +149: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +149: [sniffer_whitespace_scopeindent_incorrect, minor] Line indented incorrectly; expected 4 spaces, found 5
 +149: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +150: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +150: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +150: [style_trailing_spaces, minor] There should be no trailing spaces
 +151: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +151: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +152: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +152: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +153: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +153: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +154: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +154: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +155: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +155: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +155: [style_trailing_spaces, minor] There should be no trailing spaces
 +156: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +156: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +157: [style_trailing_spaces, minor] There should be no trailing spaces
 +167: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +167: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +168: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +168: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +168: [style_trailing_spaces, minor] There should be no trailing spaces
 +169: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 4 spaces, found 5
 +169: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +169: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +171: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +171: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +173: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +173: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +173: [style_control_spacing, normal] Control statements should have one space between the control keyword and opening parenthesis
 +174: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 4 spaces, found 3
 +174: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +174: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +175: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +175: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +176: [sniffer_squiz_whitespace_superfluouswhitespace_emptylines, minor] Functions must not contain multiple empty lines in a row; found 2 empty lines
 +178: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +178: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +191: [sniffer_squiz_whitespace_superfluouswhitespace_emptylines, minor] Functions must not contain multiple empty lines in a row; found 2 empty lines
 +193: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +193: [sniffer_controlstructures_controlsignature, minor] Expected "foreach (...) {\n"; found "foreach(...)\n\t\t{\n"
 +193: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +193: [style_control_spacing, normal] Control statements should have one space between the control keyword and opening parenthesis
 +194: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +194: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +194: [style_curly_braces, normal] curly braces { should end a line, not start one
 +195: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 4 spaces, found 3
 +195: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +195: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +195: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +195: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +195: [style_comma_spacing, normal] missing space after comma
 +196: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +196: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +196: [style_trailing_spaces, minor] There should be no trailing spaces
 +197: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 4 spaces, found 3
 +197: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +197: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +200: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 4 spaces, found 3
 +202: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 4 spaces, found 3
 +202: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +202: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +204: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +204: [sniffer_controlstructures_controlsignature, minor] Expected "if (...) {\n"; found "if(...)\n\t\t\t{\n"
 +204: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +204: [style_control_spacing, normal] Control statements should have one space between the control keyword and opening parenthesis
 +205: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +205: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +205: [style_curly_braces, normal] curly braces { should end a line, not start one
 +206: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 6 spaces, found 4
 +206: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +206: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +207: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +207: [sniffer_whitespace_scopeindent_incorrect, minor] Line indented incorrectly; expected 6 spaces, found 4
 +207: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +208: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 8 spaces, found 5
 +208: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +208: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +210: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +210: [sniffer_controlstructures_controlsignature, minor] Expected "if (...) {\n"; found "if(...)\n\t\t\t\t\t{\n"
 +210: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +210: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +210: [style_control_spacing, normal] Control statements should have one space between the control keyword and opening parenthesis
 +210: [style_comma_spacing, normal] missing space after comma
 +211: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +211: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +211: [style_curly_braces, normal] curly braces { should end a line, not start one
 +212: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +212: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +212: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +212: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +212: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +212: [style_comma_spacing, normal] missing space after comma
 +213: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +213: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +213: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +213: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +213: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +213: [style_comma_spacing, normal] missing space after comma
 +214: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +214: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +216: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +216: [sniffer_controlstructures_controlsignature, minor] Expected "if (...) {\n"; found "if(...)\n\t\t\t\t\t{\n"
 +216: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +216: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +216: [style_control_spacing, normal] Control statements should have one space between the control keyword and opening parenthesis
 +216: [style_comma_spacing, normal] missing space after comma
 +217: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +217: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +217: [style_curly_braces, normal] curly braces { should end a line, not start one
 +218: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +218: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +218: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +218: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +218: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +218: [style_comma_spacing, normal] missing space after comma
 +219: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +219: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +219: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +219: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +219: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +219: [style_comma_spacing, normal] missing space after comma
 +221: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +221: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +221: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +223: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +223: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +225: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +225: [sniffer_controlstructures_controlsignature, minor] Expected "if (...) {\n"; found "if(...)\n\t\t\t\t\t{\n"
 +225: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +225: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +225: [style_control_spacing, normal] Control statements should have one space between the control keyword and opening parenthesis
 +225: [style_comma_spacing, normal] missing space after comma
 +226: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +226: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +226: [style_curly_braces, normal] curly braces { should end a line, not start one
 +227: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +227: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +227: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +227: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +227: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +227: [style_comma_spacing, normal] missing space after comma
 +228: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +228: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +228: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +228: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +228: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +228: [style_comma_spacing, normal] missing space after comma
 +229: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +229: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +229: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +229: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +229: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +229: [style_comma_spacing, normal] missing space after comma
 +230: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +230: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +230: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +230: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +230: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +230: [style_comma_spacing, normal] missing space after comma
 +231: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +231: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +231: [sniffer_generic_functions_functioncallargumentspacing_nospaceaftercomma, minor] No space found after comma in function call
 +231: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +231: [style_comma_spacing, normal] missing space after comma
 +232: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +232: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +232: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +233: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +233: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +233: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +234: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +234: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +234: [style_trailing_spaces, minor] There should be no trailing spaces
 +235: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +235: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +235: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +237: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 10 spaces, found 6
 +237: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +237: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +248: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +248: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +250: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +250: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +252: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 6 spaces, found 5
 +252: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +252: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +254: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +254: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +255: [sniffer_squiz_whitespace_superfluouswhitespace_emptylines, minor] Functions must not contain multiple empty lines in a row; found 3 empty lines
 +258: [sniffer_whitespace_scopeclosingbrace_indent, minor] Closing brace indented incorrectly; expected 2 spaces, found 3
 +258: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +258: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +259: [sniffer_whitespace_scopeindent_incorrectexact, minor] Line indented incorrectly; expected 2 spaces, found 3
 +259: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +259: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +260: [sniffer_squiz_whitespace_superfluouswhitespace_emptylines, minor] Functions must not contain multiple empty lines in a row; found 4 empty lines
 +261: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +261: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs
 +261: [style_trailing_spaces, minor] There should be no trailing spaces
 +264: [sniffer_generic_whitespace_disallowtabindent_tabsused, minor] Spaces must be used to indent lines; tabs are not allowed
 +264: [style_no_tabs, normal] Use an indent of 2 spaces, with no tabs

Status Messages:
 Coder found 3 projects, 3 files, 137 normal warnings, 277 minor warnings, 0 warnings were flagged to be ignored

Comment #2

hwi2 commented 4 September 2014 at 02:18

Thanks, Mark. The warnings have been cleaned up. I used the Coder module.

From Coder:

SITES/ALL/MODULES/QUICK_VIEWS_DISPLAY_LIST/QUICK_VIEWS_DISPLAY_LIST.MODULE
quick_views_display_list.module

No Problems Found

Thanks!
Bruce

Comment #3

hwi2 commented 4 September 2014 at 14:37

Title:	Code review	» [D7] Quick Views Display List
Project:	Quick Views Display List	» Drupal.org security advisory coverage applications
Component:	Code	» module
Issue summary:	View changes
Status:	Active	» Needs review
Issue tags:		+PAreview: review bonus

Comment #4

hwi2 commented 4 September 2014 at 14:52

Issue summary:

View changes

Comment #5

hwi2 commented 4 September 2014 at 14:53

Issue summary:

View changes

Comment #6

hwi2 commented 4 September 2014 at 15:40

Issue summary:

View changes

Comment #7

lokapujya

English

Boston

commented 4 September 2014 at 15:53

Nice work on this module. I will be trying it out. Also, thanks for reviewing some of the other projects.

Make sure that when running Coder that you check off minor(most) so that it will catch the line spacing issues mentioned in comment #1.
Please read writing-secure-code
For example, in quick_views_display_list on line 221:
```
<?php
$display_link = "<a href='$base_url?q=admin/structure/views/view/$viewmname/edit/$display_mn'>$display_title</a><br/>";
?>
```
the output should be checked to make sure it doesn't contain HTML. Actually, you might want to look into using the l() function for creating links.
You shouldn't need that $db_prefix code; I think you can just add {} around the table name. See Prefixing, under https://www.drupal.org/node/310072
files[] without classes or interfaces

files[] = quick_views_display_list.module
Those lines should be removed. It's only necessary to declare files[] if they declare a class or interface.
Please note: The Coder module currently has an unresolved flaw which will prompt you to add file declarations to your .info file even when it's not necessary to do so. Please do not try to make this warning go away by declaring files which do not contain classes or interfaces.

files[] = quick_views_display_list.views_default.inc
I don't see this file in the project.

Comment #8

lokapujya

English

Boston

commented 4 September 2014 at 15:56

Status:

Needs review

» Needs work

Comment #9

hwi2 commented 4 September 2014 at 16:29

Good suggestions, lokapujya. Thanks!

Bruce

Comment #10

hwi2 commented 5 September 2014 at 02:20

Dear lokapujya,
I made the following changes:
1. Ran Coder in Minor and removed those issues.
2. Replaced all links with l(). Added XSS_filter and other security code.
3. Made changes to db tables.
4. Removed $files[] from the .info file.

Comment #11

hwi2 commented 5 September 2014 at 03:21

Status:

Needs work

» Needs review

Comment #12

hwi2 commented 5 September 2014 at 04:21

Issue summary:

View changes

Comment #13

PA robot commented 5 September 2014 at 04:23

Status:

Needs review

» Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxhwi22330527git

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #14

rob.barnett commented 5 September 2014 at 13:19

Status	File	Size
new	quick_views_errors.txt	14.61 KB

Hi Bruce,

Fantastic module. Very useful. Attached are results from my automated review using codesniffer and drush - if you have drush installed: https://www.drupal.org/node/1419988: drush drupalcs

One point of confusion I had was after I installed your module and I go to Quick Views Display List, it shows views from a contrib module I have installed, Statuses, under Views in Database as just
Block
Defaults
Feed
Page
I looked at Statuses and its view comes from statuses/includes/views/statuses.views_default.inc. Shouldn't they appear under Views in Code? I'm also unclear why the have the generic titles: Block, Defaults, Feed, and Page. The other views show their view names.

Everything else displays correctly.

I would also suggest naming function list_table more specifically such as prefixing them with your module name. That way there is little risk in creating duplicate function names with other modules.

Excellent work.

Comment #15

PA robot commented 18 November 2014 at 17:24

Status:

Needs work

» Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

[D7] Quick Views Display List

Reviews of other projects

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

News items

Our community

Documentation

Drupal code base

Governance of community