I have a sandbox project and wish to promote it as a full project.
It is a module project.
Project Name: CtrlV
Link: https://www.drupal.org/sandbox/yelban/2330529
Clone:
git clone http://git.drupal.org/sandbox/yelban/2330529.git
Description: CtrlV is a invisiable image upload tool.
Paste a local image from clipboard to CKEditor, The module takes the base64 data-encoded URI images and converts them into normal files when a node is saved.
you can also paste selections from your favorite image editor such like Photoshop, Snagit, Powerpoint, Word..., too.
It should be the easiest way to upload images to a node.
The module make Your Site more User-Friendly and building a better User Experience.
Works only in Internet Explorer 11+ and Mozilla Firefox browsers.
Version: 7.x
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | ctrlv_v7.1.x.zip | 53.68 KB | yelban |
Comments
Comment #1
pkamerakodi commentedHi,
Thanks for the contribution, mean while some small suggestions if you like to update.
Automated Review as some warnings and errors
http://pareview.sh/pareview/httpgitdrupalorgsandboxyelban2330529git
Manual Review
Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements
3rd party code
Yes: Follows the guidelines for 3rd party code.
README.txt/README.md
Yes
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
YES
Coding style & Drupal API usage
1) I think so this is not the right way to get public folder path
variable_get('file_public_path', conf_path() . '/files') instead it is better to use
$path = 'public://custom_map';
drupal_realpath($path);
2) Please implement unistall hook to delete non used variables
3) May be it is better to have this option for all other fields apart from body itself.
4) I think it is better call https://api.drupal.org/api/drupal/includes!file.inc/function/file_prepar... then calling file_exists and then calling drupal_mkdir.
5) return; in presave hook is not necessary.
Prajwal
Comment #2
pkamerakodi commentedComment #3
yelban commentedHi pkamerakodi,
Thanks for your review, change has been done.
including suggestion 3) this option is for all other fields now^^
also add token support at image upload path.
Comment #4
yelban commentedComment #5
PA robot commentedGit clone command for the sandbox is missing in the issue summary, please add it.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #6
yelban commentedComment #7
yelban commentedComment #8
yelban commentedComment #9
yelban commentedComment #10
yelban commentedComment #11
yelban commentedComment #12
yelban commentedComment #13
yelban commentedComment #14
yelban commentedThere are no error reported by automated review tools.
needs review again, Thanks a lot.
Comment #15
yelban commentedComment #16
pfu.mi@outlook.com commenteda.) Due to you have dependencies of CkEditor OR WYSIWYG you could alert a user when enabling your module to maybe install one of these. You could implement hook_enable in your .install and check for module_exists('').
b.) Coder responded:
Line 36: missing space after comma [style_comma_spacing]
$type_textarea = array('text_textarea','text_textarea_with_summary');
c.) If I added an image and then remove it and save the node, it gets not removed from server. Normally when I upload an image to a node I have the possibility to remove the image as well via drupal. The possible solution would be (when it got already uploaded via your module) to have it selectable at the predefined Image field, so it can be removed.
d.) "Works only in Internet Explorer 11+ and Mozilla Firefox browsers."
I tested it in IE11, but I can't copy my local image into the CKEditor. In Firefox it works fine.
Comment #17
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.