Blocked on #2313757: Remove text_processing option from text fields, expose existing string field types as plain text in UI.

See #37.5 and #48.5 regarding that.

+++ b/core/modules/quickedit/src/Plugin/InPlaceEditor/PlainTextEditor.php
@@ -32,8 +29,8 @@ public function isCompatible(FieldItemListInterface $items) {
-    // This editor is incompatible with processed ("rich") text fields.
-    elseif ($field_definition->getSetting('text_processing')) {
+    // This editor is incompatible with filtered ("rich") text fields.
+    elseif (in_array($field_definition->getType(), array('text', 'text_long', 'text_with_summary'))) {

This was only necessary because text fields could previously be both filtered and unfiltered (plain), depending on the configuration. Since this is no longer possible, this if-statement can be removed and we just don't tag the processed text fields with the plain_text in-place editor anymore.

Except that removing that no longer associating the plain_text in-place editor anymore with filtered text fields no longer allows the editor.module's Editor (WYSIWYG) in-place editor to automatically declare itself as an alternative to the plain text in-place editor.

In other words: we'll need to revise how all that works.

Comments

mgifford’s picture

Status: Postponed » Active

Ok, that block seems to be fixed...

wim leers’s picture

Title: [PP-1] Refactor PlainTextEditor/WysiwygEditor/Editor in-place editors now that text fields no longer have configurable filteredness » Refactor PlainTextEditor/WysiwygEditor/Editor in-place editors now that text fields no longer have configurable filteredness

Indeed.

wim leers’s picture

Assigned: wim leers » Unassigned
Status: Active » Needs review
StatusFileSize
new6.03 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2327941-3.patch, failed testing.

wim leers’s picture

Status: Needs work » Needs review

Re-testing.

nod_’s picture

Not up to speed on the rationale, but the alternative did get removed properly. If we're green RTBC for me.

Status: Needs review » Needs work

The last submitted patch, 3: 2327941-3.patch, failed testing.

The last submitted patch, 3: 2327941-3.patch, failed testing.

wim leers’s picture

The rationale is in the IS. Working on fixing the test failures.

wim leers’s picture

Status: Needs work » Needs review
StatusFileSize
new8.33 KB
new5.15 KB

Here we go.

yched’s picture

Status: Needs review » Reviewed & tested by the community

Green, looks good to me too, RTBC then ?

wim leers’s picture

I think it's ready, yes.

+++ b/core/modules/editor/src/Plugin/InPlaceEditor/Editor.php
@@ -35,16 +34,14 @@ public function isCompatible(FieldItemListInterface $items) {
-    elseif (in_array($field_definition->getType(), array('text', 'text_long', 'text_with_summary'), TRUE)) {

+++ b/core/modules/quickedit/src/Plugin/InPlaceEditor/PlainTextEditor.php
@@ -26,16 +26,7 @@ public function isCompatible(FieldItemListInterface $items) {
-    // This editor is incompatible with formatted ("rich") text fields.
-    elseif (in_array($field_definition->getType(), array('text', 'text_long', 'text_with_summary'), TRUE)) {

This tight coupling of a specific in-place editor to a specific set of fields, i.e. this not supporting any contrib fields is then finally resolved. :)

yched’s picture

@Wim : Oh, yay indeed :-)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: 2327941-10.patch, failed testing.

wim leers’s picture

Status: Needs work » Reviewed & tested by the community

Ugh, this was RTBC since October 1, it just failed randomly because PIFR is always drunk nowadays.

wim leers’s picture

Title: Refactor PlainTextEditor/WysiwygEditor/Editor in-place editors now that text fields no longer have configurable filteredness » Simplify in-place editor selection (Was: Refactor PlainTextEditor/WysiwygEditor/Editor in-place editors now that text fields no longer have configurable filteredness)
Issue tags: +rc deadline

D'oh, I forgot to tag this rc deadline…

catch’s picture

Issue tags: -rc deadline +rc target triage, +Needs issue summary update
xjm’s picture

Status: Reviewed & tested by the community » Needs work

Thanks for tagging this for rc target triage! To have committers consider it for inclusion in RC, we should add a statement to the issue summary of why we need to make this change during RC, including what happens if we do not make the change and what any disruptions from it are. We can add a section <h3>Why this should be an RC target</h3> to the summary.

xjm’s picture

Issue tags: -rc target triage

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

The last submitted patch, 10: 2327941-10.patch, failed testing.

jonathanshaw’s picture

Issue tags: +Needs reroll
Sonal.Sangale’s picture

Assigned: Unassigned » Sonal.Sangale
Status: Needs work » Needs review
StatusFileSize
new7.89 KB

Rerolled the patch.

jonathanshaw’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

This was previously RTBC in #11/12, but fell at D8.0 RC target triage. Presumably it's therefore good for D8.1

  • catch committed bc084e1 on 8.2.x
    Issue #2327941 by Wim Leers, Sonal.Sangale: Simplify in-place editor...
catch’s picture

Version: 8.1.x-dev » 8.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x

There are minor changes to the annotation etc. which don't make this look immediately applicable to 8.1.x, also no functional bug, so didn't cherry-pick back.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.