See #37.5 and #48.5 regarding that.
+++ b/core/modules/quickedit/src/Plugin/InPlaceEditor/PlainTextEditor.php
@@ -32,8 +29,8 @@ public function isCompatible(FieldItemListInterface $items) {
- // This editor is incompatible with processed ("rich") text fields.
- elseif ($field_definition->getSetting('text_processing')) {
+ // This editor is incompatible with filtered ("rich") text fields.
+ elseif (in_array($field_definition->getType(), array('text', 'text_long', 'text_with_summary'))) {
This was only necessary because text fields could previously be both filtered and unfiltered (plain), depending on the configuration. Since this is no longer possible, this if-statement can be removed and we just don't tag the processed text fields with the plain_text in-place editor anymore.
Except that removing that no longer associating the plain_text in-place editor anymore with filtered text fields no longer allows the editor.module's Editor (WYSIWYG) in-place editor to automatically declare itself as an alternative to the plain text in-place editor.
In other words: we'll need to revise how all that works.
| Comment | File | Size | Author |
|---|---|---|---|
| #23 | 2723941-23.patch | 7.89 KB | Sonal.Sangale |
| #10 | 2327941-10.patch | 8.33 KB | wim leers |
Comments
Comment #1
mgiffordOk, that block seems to be fixed...
Comment #2
wim leersIndeed.
Comment #3
wim leersComment #5
wim leersRe-testing.
Comment #6
nod_Not up to speed on the rationale, but the alternative did get removed properly. If we're green RTBC for me.
Comment #9
wim leersThe rationale is in the IS. Working on fixing the test failures.
Comment #10
wim leersHere we go.
Comment #11
yched commentedGreen, looks good to me too, RTBC then ?
Comment #12
wim leersI think it's ready, yes.
This tight coupling of a specific in-place editor to a specific set of fields, i.e. this not supporting any contrib fields is then finally resolved. :)
Comment #13
yched commented@Wim : Oh, yay indeed :-)
Comment #15
wim leersUgh, this was RTBC since October 1, it just failed randomly because PIFR is always drunk nowadays.
Comment #16
wim leersD'oh, I forgot to tag this …
Comment #17
catchComment #18
xjmThanks for tagging this for rc target triage! To have committers consider it for inclusion in RC, we should add a statement to the issue summary of why we need to make this change during RC, including what happens if we do not make the change and what any disruptions from it are. We can add a section
<h3>Why this should be an RC target</h3>to the summary.Comment #19
xjmComment #22
jonathanshawComment #23
Sonal.Sangale commentedRerolled the patch.
Comment #24
jonathanshawThis was previously RTBC in #11/12, but fell at D8.0 RC target triage. Presumably it's therefore good for D8.1
Comment #26
catchCommitted/pushed to 8.2.x
There are minor changes to the annotation etc. which don't make this look immediately applicable to 8.1.x, also no functional bug, so didn't cherry-pick back.