Follow-up to #2318251: Make comment links functionality testable and convert CommentLinkTest to PHPUnit

Problem/Motivation

According #2322889: Various setUp() and tearDown() methods are not protected the setUp() should be protected

Proposed resolution

Fix visibility of the method

Remaining tasks

File a patch

User interface changes

No

API changes

No

CommentFileSizeAuthor
#2 setup_should_be_protected-2324783-2.patch717 bytesJayeshSolanki

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Sorry, my fault

JayeshSolanki’s picture

JayeshSolanki commented
Status: Needs work » Needs review
StatusFileSize
new setup_should_be_protected-2324783-2.patch717 bytes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Thanx

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 50dfcc7 and pushed to 8.0.x. Thanks!

  • alexpott committed 50dfcc7 on 8.0.x 
    Issue #2324783 by JayeshSolanki | andypost: Fixed CommentLinkBuilderTest...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.