Closed (fixed)
Project:
Swift Mailer (abandoned)
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
14 Aug 2014 at 10:35 UTC
Updated:
10 Feb 2018 at 22:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jelle_sPatch is attached.
Comment #2
jelle_sFixed typos in readme.
Comment #3
b-prod commentedThis patch is OK.
Note that, as specified in the issue properties, it does not apply to the current release, but only to the DEV version. But the parts of the patch that does not apply are related to the README.txt file, so the patch can be used on the current release for those who need it.
Comment #4
sbrattla commentedApplied patch to 7.x-1.x-dev. Thanks!
Comment #5
sbrattla commentedComment #6
webflo commentedComment #7
quadbyte commentedHere is my port for D8. I have added third parameter to the alter hook : $message which holds the original drupal message array, which may be useful to pass additional data to the hook.
Comment #9
quadbyte commentedfixing patch carriage return.
Comment #10
webflo commentedWe should inject the module handler.
Comment #11
jcisio commentedFix #10. I've changed the comment a little and remove the reference to the objects, which usually are not necessary and to keep it on par with D7.
Comment #12
webflo commentedPatch no longer applies.
Isn't it possible to user \Drupal\Core\Extension\ModuleHandlerInterface::alter?
Comment #13
webflo commentedComment #14
webflo commentedComment #15
webflo commentedunused property.
Comment #16
webflo commentedComment #17
tstoecklerThis happens in all cases, so I think it can just be moved to after the switch.
The
$addressesparameter is type-hinted as an array, so maybe put the address in an array.Comment #18
webflo commentedComment #19
tstoecklerLooks good to me, thanks.
Comment #23
webflo commented