Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Right now it is impossible for contrib modules to provide additional settings for Swift. If there would be an alter hook, that is invoked before sending the email, contrib modules can provide their settings and apply them in the alter hook.
Patch will follow.
Comment | File | Size | Author |
---|---|---|---|
#18 | 2321215-18.patch | 8.68 KB | webflo |
| |||
#16 | 2321215-16.patch | 7.6 KB | webflo |
| |||
#14 | 2321215-14.patch | 7.13 KB | webflo |
| |||
#13 | 2321215-13.patch | 2 KB | webflo |
| |||
#11 | 2321215-swiftmailer_alter-11-interdiff.diff | 705 bytes | jcisio |
Comments
Comment #1
Jelle_SPatch is attached.
Comment #2
Jelle_SFixed typos in readme.
Comment #3
B-Prod CreditAttribution: B-Prod commentedThis patch is OK.
Note that, as specified in the issue properties, it does not apply to the current release, but only to the DEV version. But the parts of the patch that does not apply are related to the README.txt file, so the patch can be used on the current release for those who need it.
Comment #4
sbrattla CreditAttribution: sbrattla commentedApplied patch to 7.x-1.x-dev. Thanks!
Comment #5
sbrattla CreditAttribution: sbrattla commentedComment #6
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #7
quadbyte CreditAttribution: quadbyte commentedHere is my port for D8. I have added third parameter to the alter hook : $message which holds the original drupal message array, which may be useful to pass additional data to the hook.
Comment #9
quadbyte CreditAttribution: quadbyte commentedfixing patch carriage return.
Comment #10
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedWe should inject the module handler.
Comment #11
jcisio CreditAttribution: jcisio as a volunteer and at Axess Open Web Services commentedFix #10. I've changed the comment a little and remove the reference to the objects, which usually are not necessary and to keep it on par with D7.
Comment #12
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedPatch no longer applies.
Isn't it possible to user \Drupal\Core\Extension\ModuleHandlerInterface::alter?
Comment #13
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #14
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #15
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedunused property.
Comment #16
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #17
tstoecklerThis happens in all cases, so I think it can just be moved to after the switch.
The
$addresses
parameter is type-hinted as an array, so maybe put the address in an array.Comment #18
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #19
tstoecklerLooks good to me, thanks.
Comment #23
webflo CreditAttribution: webflo at UEBERBIT GmbH commented