Move batch processing to a service

1. +++ b/core/includes/batch.inc
   @@ -210,133 +210,11 @@ function _batch_progress_page() {
    function _batch_process() {
   
   @@ -357,6 +235,8 @@ function _batch_process() {
     * @see _batch_process()
   ...
    function _batch_api_percentage($total, $current) {
   
   @@ -364,10 +244,11 @@ function _batch_api_percentage($total, $current) {
    function &_batch_current_set() {
   
   @@ -379,20 +260,11 @@ function &_batch_current_set() {
    function _batch_next_set() {
   
   @@ -402,90 +274,7 @@ function _batch_next_set() {
    function _batch_finished() {
   
   +++ b/core/includes/form.inc
   @@ -3035,26 +3035,12 @@ function &batch_get() {
    function _batch_populate_queue(&$batch, $set_id) {
   
   @@ -3065,23 +3051,11 @@ function _batch_populate_queue(&$batch, $set_id) {
    function _batch_queue($batch_set) {
   

   These are internal functions already, can't you get rid of them directly?

2. +++ b/core/lib/Drupal/Core/Batch/BatchProcessor.php
   @@ -0,0 +1,324 @@
   +
   +require_once DRUPAL_ROOT . '/core/includes/form.inc';
   +
   

   :(

3. +++ b/core/lib/Drupal/Core/Batch/BatchProcessor.php
   @@ -0,0 +1,324 @@
   +        include_once DRUPAL_ROOT . '/' . $current_set['file'];
   

   If we do have a service you can use %app.root%

4. +++ b/core/lib/Drupal/Core/Batch/BatchProcessor.php
   @@ -0,0 +1,324 @@
   +        $redirect = $_batch['batch_redirect'] ?: $_batch['source_url'];
   +        $options = UrlHelper::parse($redirect);
   +        if (!UrlHelper::isExternal($options['path'])) {
   +          $options['path'] = $GLOBALS['base_url'] . '/' . $options['path'];
   +        }
   +        $redirect = Url::createFromPath($options['path']);
   +        $redirect->setOptions($options);
   +        $_batch['form_state']->setRedirectUrl($redirect);
   

   Follow up: Would be great if this batch_redirect would also just support an URL object, so route name + parameter.

5. +++ b/core/lib/Drupal/Core/Batch/BatchProcessorInterface.php
   @@ -0,0 +1,56 @@
   +interface BatchProcessorInterface {
   

   Cool, this interface actually looks nice!

6. +++ b/core/lib/Drupal/Core/Batch/BatchQueueHandlerInterface.php
   @@ -0,0 +1,43 @@
   +   * Depending on whether the batch is progressive or not, the
   +   * Drupal\Core\Queue\Batch or Drupal\Core\Queue\BatchMemory handler classes
   +   * will be used.
   +   *
   +   * @param array $batch
   +   *   The batch array.
   

   Here could be a good place to actually document the entries of a batch thing. At some time then we can convert this to a new value object, which then would allow actual documentation. yeah!

Conflict: http://cgit.drupalcode.org/drupal/commit/core/includes/batch.inc?id=dbed...

Resolved but currently this patch breaks the careful balance of the batch global hacks. Looking into it.

Is this now 8.1 or 9.0 territory (sadly)? Or can we keep the functional stuff as BC?

Rerolled

Rerolled

Will work on that for a while. This could fix some stuff already.

• Remove old code, BC layer is no needed as all methods have been internal and replaced by the new service.

Meh tests ...

Move batch_process() to the service itself.

Move batch_process() to the service itself.

This is not really needed in this issue, let's skip it.

Something strange was introduced in #31. I just commented it.

There is a two step process underway in other tickets.

First, change the batch api to be OO rather than procedural - https://www.drupal.org/node/2401797

Then change the batch processing to a service - https://www.drupal.org/node/2875151

The code in Introduce a batch object to make the batch API easier to use is currently applying cleanly to 8.5.x, so I'd like to continue with that. (But then I'm biased.)

I'd like to know what @kim.pepper, @pguillard, and @Nitesh Sethia think, as they've done a lot of the work on this patch.

I'm marking this issue as "Duplicate" in favor of #2401797: Introduce a batch builder class to make the batch API easier to use and #2875151: [META] Implement Batch API as a service.

I've placed a comment on #2875151 requesting that the contributors here are credited on that issue instead. If you contributed to this issue, please go to #2875151: [META] Implement Batch API as a service and comment to help the committer give you credit.