Can't unpublish a comment

/me working on tests

Added a test.
Also added ::getStatus to CommentInterface.
Seems counter intuitive to use isPublished to convert status to a bool and then convert it back again.
Thanks @thehong!

Thank you we have test fail which shows it is fixed so RTBC.

+++ b/core/modules/comment/src/CommentForm.php
@@ -114,7 +114,7 @@ public function form(array $form, FormStateInterface $form_state) {
-      $status = $comment->isPublished();
+      $status = $comment->getStatus();

I'd prefer do not introduce a new method without test coverage
$status = $comment->isPublished() ? CommentInterface::PUBLISHED : CommentInterface::NOT_PUBLISHED
should work

Well, the regression test inherently tests the new method.

The reason I added a getStatus method is isPublished does this:

$this->get('status')->value == CommentInterface::PUBLISHED

so if we use isPublished() we're effectively writing this:

$status = ($this->get('status')->value == CommentInterface::PUBLISHED) ? CommentInterface::PUBLISHED : CommentInterface::NOT_PUBLISHED;

Which I think is inefficient.

Happy to add a unit test for CommentInterface::getStatus if that helps

I'm not sure a unit test adds much value here. Committed 95019fa and pushed to 8.0.x. Thanks!

diff --git a/core/modules/comment/src/CommentInterface.php b/core/modules/comment/src/CommentInterface.php
index bbf502a..e7a4ee9 100644
--- a/core/modules/comment/src/CommentInterface.php
+++ b/core/modules/comment/src/CommentInterface.php
@@ -216,7 +216,7 @@ public function isPublished();
    * Returns the comment's status.
    *
    * @return int
-   *   One of CommentInterface::PUBLISHED or CommentInterface::UNPUBLISHED
+   *   One of CommentInterface::PUBLISHED or CommentInterface::NOT_PUBLISHED
    */
   public function getStatus();

Fixed on commit.