Extra div after ajax updates

@Chris The issue is with ajax_command_replace(). Will remove the extra newlines that comes from the template file, as suggested here: https://api.drupal.org/comment/32698#comment-32698. Will fix this issue soon. Thanks!

After some research I found that the solution mentioned here https://api.drupal.org/comment/32698#comment-32698 does indeed removes the div wrapper. But I am still getting a div wrapper with display: block. Might be some other issue.

@Chris I looked into the issue for hours and was really confused. Everything is okay with the template that is shown through ajax_command_replace(), seems like ajax_command_replace() works like that only. Will try to figure out something soon, or will have to find some other way round. Apart from bug fixing I am also working on new features of this module. Will let you know if I find anything :) Thanks!

Possibly related, patch needs review: #2416037: theme_html_tag doesn't check that div is missing a #value and incorrectly tries to self-close

Is this still happening after that fix mentioned in #7?

Yes. Infact I am working on this issue right, and I guess I will be able to fix this. Will come up with a patch in few days or by this coming weekend :)

Ok cool, let us know the Steps to Reproduce so we can manually test, gladly test it out:)

Hi,

For me it was adding more divs due to the fact that the ajax_command_replace uses the theme function from a template file (that I have added extra divs to).

To get this to work I wrapped the whole template file (dc-ajax-shopping-cart.tpl.php after the if($order && $quantity != 0): function) with the ajax-shopping-cart-wrapper div instead of having it wrapping just the products_list_html.

<?php $content = ''; ?>
<?php if($order && $quantity != 0): ?>
<div class="ajax-shopping-cart-wrapper">
....
  <div class="custom divs">
         <!-- here comes the list that needs to be updated -->
        <?php print $products_list_html; ?>

<div class="more custom divs">
....
</div><!-- closing ajax-shopping-cart-wrapper -->
<?php endif; ?>

To remove the extra <div style="display:block;"> I removed the new lines as suggested

$new_markup = str_replace(array("\r", "\n"), '', $ajax_shopping_cart_content);
$commands[] = ajax_command_replace('.ajax-shopping-cart-wrapper', $new_markup);

I also removed the div selector in: div.ajax-shopping-cart-wrapper that seamed to mess upp the markup. (When doing ajax_command_replace i also usually use id instead of class if that is possible, but classes should work to ofcourse..)

/Mats

The last commit will fix the issue. I am not using ajax_command_replace() anymore for replacing the cart content. I have introduced a new Ajax command dc_ajax_add_cart_command_html() that does the same thing as ajax_command_replace(), just it won't add an extra wrapper div with style display: block.

The code needs to be optimized, and automated tests needs to be written. I will carry them out in another issue.

Thanks @matsjacobsson for your suggestion. But using a separate Ajax command seems a cleaner approach here.