Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow-up to #2285083: Rename contact category to contact form
Problem/Motivation
class ContactStorageTest extends ContactSitewideTest { so all test* methods are executed twice
This is by design.
Proposed resolution
Add a comment so it is clear that this is by design to prevent removal
Remaining tasks
Review
User interface changes
no
API changes
no
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | contact-storage-sitewide.1.patch | 1.16 KB | larowlan |
Comments
Comment #1
andypostComment #2
larowlanFwiw it was by design, to ensure contact module still worked with storage on. Maybe if we named the method the same and called the parent first it would be obvious what the intention was, plus we'd save another install.
Comment #3
aboros CreditAttribution: aboros commentedpicking up.
Comment #4
aboros CreditAttribution: aboros commentedIt leads to areas where i have never been before, so i unassign it in case someone more experienced would solve it.
Comment #5
undertext CreditAttribution: undertext commentedComment #9
andypost@larowlan Suppose
ContactStorageTestjust needs a extended comment why this test is inherited and that's why the subject happens.Also it would be great to add
@see ContactStorageTesttoContactSitewideTestComment #10
larowlanSounds good
Comment #11
larowlanComment #12
larowlanComment #15
andypostLooks great!
Comment #16
alexpottCommitted 155aa8d and pushed to 8.0.x. Thanks!