references_dialog_entityreference_add_link() - Check does a filter option exists

Thank you for the patch... I can confirm this fixes the issue.

#1 patch fixes the notices, however, an field configured to use an un-filtered user view still does not get an add link.
The attach patch checks if any bundles were found after all the possible bundle determination logic.

I try patch #3 with an entityreference field with bundle filtered by views. In my case I need to reference a taxonomy term for a specific vocabulary.

The add link appear for each vocabulary instead....

I have the same problem as @MarcoPBazz. I think it's odd that we always check for the "type" bundle key, only because we are using the "view" mode. For example, taxonomy terms use "machine_name" instead of "type".
As we cannot be sure of the bundle key, we should look for the right one instead of retrieving all the bundles as the previous patch does.

Maybe I'm missing something because it's possible the code in "references_dialog_entityreference_views_query" is made for this ? If not, here is my patch.

@Nishruu I try your patch but it didn't work....Maybe i'm missing something with the view? i'ts a simple view filtered by vocabulary (i'm using latest dev version of this module and the latest stable release of entity reference).

You should use a filter on "vocabulary : machine name".

nb : the patch failed testing probably because i'm on dev. I'll submit it for the stable later.

Got it, i was filtering by taxonomy term vocabulary. Changing to vocabulary : machine name solved the problem, and now it works!

thank you so much

Thanks for the tip.

Wrong patch again, sorry. I hope this time it's ok.

also resolved #2398545: Notice: Undefined index: type in references_dialog_entityreference_add_link()(line 247 of .../references_dialog.dialog_widgets.inc).

Thanks everyone!

This introduced a bug.

"Notice: Undefined variable: views_filters in references_dialog_entityreference_add_link()"

function references_dialog_entityreference_add_link($element, $widget_settings, $field, $instance) {
  [..]
    if (isset($views_display[$display]->display_options['filters'][$bundle_key])) {
      $views_filters = $views_display[$display]->display_options['filters'][$bundle_key]['value'];
    }
    else if (!empty($views_display['default']->display_options['filters'][$bundle_key]['value'])) {
      $views_filters = $views_display['default']->display_options['filters'][$bundle_key]['value'];
    }

    $bundles = array_keys($views_filters);

There is no final else { case.
So it is no longer guaranteed that $views_filters is defined.

It seems I've got #19 fixed by propagating to using all bundles if there are no bundle keys (e.g. user entity doesn't have any) and also using all bundles if there's no filter set by bundle key in the view so $views_filters is left undefined.

Looks good to me-- thanks for the patch. Can we get 1 more person to apply the patch and test?

Have tested out the addition and seems to work as I would expect. Thanks.

Patch #20 works for me too. Thank you!