When editing a user profile, if the password field is left blank and it does not get focus it shouldn't be reported as "weak", since obviously it means I will keep the current password.

Expected behavior: The password strength indicator is activated only when the password field gets focus. This is in line with earlier versions of the module.

Actual behavior: The password strength indicator is always active, meaning that if the field is untouched (i.e., I simply don't want to change password and that field never gets focus) the password is reported as "weak"; this may confuse users.

Screenshot:

CommentFileSizeAuthor
#6 cgit-patch-url.jpg426.44 KBmarkhalliwell
#6 commit-cgit-url.jpg137.13 KBmarkhalliwell
#6 issue-commit-url.jpg45.66 KBmarkhalliwell
#5 password_strength-2316655-5.patch767 bytesmkhamash
bootstrap-password-focus.png21.61 KBpescetti
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Status: Active » Fixed

  • Mark Carver committed 6ac8dd8 on 7.x-3.x 
    Issue #2316655 by pescetti: Fixed Password strength indicator should...
pescetti’s picture

pescetti CreditAttribution: pescetti commented

Thanks, I confirm it works for me now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mkhamash’s picture

mkhamash CreditAttribution: mkhamash commented
FileSize
password_strength-2316655-5.patch767 bytes

Upload the patch file so make files can use it as a patch.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
FileSize
issue-commit-url.jpg45.66 KB
commit-cgit-url.jpg137.13 KB
cgit-patch-url.jpg426.44 KB

Thanks :) FWIW though, you really don't have to. You can easily use the patch URL in the Cgit repo UI:
http://cgit.drupalcode.org/bootstrap/patch/?id=6ac8dd87182768d7d6af3d748...

Step 1:

Step 2:

Step 3: