Code Cleanup

Coder found 1 projects, 18 files, 25 normal warnings, 464 minor warnings, 0 warnings were flagged to be ignored

Will go thru these file by file to cleanup.

BACNET.MODULE
BACNET-VIEW-ROW-BARGRAPH.TPL.PHP
BACNET-VIEW-ROW-DIAL.TPL.PHP
BACNET-VIEW-ROW-LINEGRAPH.TPL.PHP
BACNET-VIEW-ROW-TEXT.TPL.PHP
BACNET-VIEW-STYLE-TREND.TPL.PHP
BACNET-VIEW-STYLE-VALUEGRAPHIC.TPL.PHP
BACNET-VIEW-STYLE-VALUETEXT.TPL.PHP
BACNET.INSTALL
BACNET.VIEWS.INC
BACNET_PLUGIN_ROW_BARGRAPH.INC
BACNET_PLUGIN_ROW_DIAL.INC
BACNET_PLUGIN_ROW_LINEGRAPH.INC
BACNET_PLUGIN_ROW_TEXT.INC
BACNET_PLUGIN_STYLE_TREND.INC
BACNET_PLUGIN_STYLE_VALUEGRAPHIC.INC
BACNET_PLUGIN_STYLE_VALUETEXT.INC
BACNET/JS/DRUPAL.BACNET.JS

On bacnet.module

Before cleanup - FOUND 192 ERRORS AND 13 WARNINGS AFFECTING 159 LINES.

After cleanup -- FOUND 6 ERRORS AND 13 WARNINGS AFFECTING 18 LINES

Patch file is attached

now going to cleanup BACNET-VIEW-ROW-BARGRAPH.TPL.PHP

Before cleanup codesniffer FOUND 13 ERRORS AFFECTING 8 LINES

After cleanup code sniffer FOUND 6 ERRORS AND 1 WARNING AFFECTING 2 LINES

Committed changes

Cleanup attempted for BACNET-VIEW-ROW-DIAL.TPL.PHP - -> Codesniffer FOUND 6 ERRORS AND 1 WARNING AFFECTING 2 LINES, but none of these were corrected when running phpcbf

Codesniffer ran on BACNET-VIEW-ROW-LINEGRAPH.TPL.PHP and FOUND 13 ERRORS AND 1 WARNING AFFECTING 9 LINES

After running phpcbf code sniffer found FOUND 6 ERRORS AND 1 WARNING AFFECTING 2 LINES

These updates were committed.

modified: bacnet.install
modified: bacnet.views.inc
modified: bacnet_plugin_row_bargraph.inc
modified: bacnet_plugin_row_dial.inc
modified: bacnet_plugin_row_linegraph.inc
modified: bacnet_plugin_row_text.inc
modified: bacnet_plugin_style_trend.inc
modified: bacnet_plugin_style_valuegraphic.inc
modified: bacnet_plugin_style_valuetext.inc

and committed

Closing out the Code cleanup for now because I completed the review and code edits using phpcbf per review comments by @Sachini.

Will create additional tickets for additional code review.

Reopening this issue to rerun codersniffer and log additional efforts to cleanup code.

Took out comments that were used to implement php code to get, cache and parse SOAP data.

Need to rerun code beautify due to all the new features that have been added.

Presently at FOUND 192 ERRORS AND 32 WARNINGS AFFECTING 166 LINES and PHPCBF CAN FIX THE 114 MARKED SNIFF VIOLATIONS AUTOMATICALLY

Running code sniffer locally from terminal appears to be having memory difficulties of some kind, so the files patched do not seem to being being saved correctly. Try making another commit to watch this more carefully.

After running cbf message corrections is down to FOUND 78 ERRORS AND 32 WARNINGS AFFECTING 83 LINES

Yep, for some reason the preview reviews do not seem to be keeping up with file updates, even though the new git address is used. So ignoring the preview for now, and just focus on local coder review, this time for bacnet.install

FOUND 102 ERRORS AND 4 WARNINGS AFFECTING 99 LINES &

PHPCBF CAN FIX THE 86 MARKED SNIFF VIOLATIONS AUTOMATICALLY

so after fix

FOUND 16 ERRORS AND 5 WARNINGS AFFECTING 16 LINES

tkuldeep17's comment's need to be addressed.

1. function bacnet_theme is no longer being used ==> I removed this.

2. you are not using $user variable anywhere ==> I removed this too.

3. use 'drupal_set_message' ==> OK, did this the Drupal way using 'drupal_set_message'

4. correct the php syntax in use of bacnet_node_form ==> I corrected this

5. There are a lot of paraview issues ==> I agree!! I'm working on these slowly but surely so make sure you are using the most recent commit. It seem like pareview does not automatically update to the most recent commit.

Using Coder module on local dev I was able to cleanup code on the bacnet.module so that Coder output returned "No Problems Found".

Using Coder module on local dev I was able to cleanup code on the bacnet.install so that Codesniffer output was clean.

Removed curly braces that were not needed.

As per comment and attached file at https://www.drupal.org/node/2312955#comment-9059829 this issue has been fixed so will mark it as closed for now.

A bit more cleanup added after adding feature request for additional content type fields.

working thru the minor warnings now.

Cleaned up most minor warnings on file bacnet_plugin_row_dial.inc.

Cleaned up most minor warnings on file bacnet_plugin_row_linegraph.inc

oops...

After making the some of the changes that Coder was asking, which is mind numbing, I thought to check before I got TOOO far into it. Went to views that were working just fine and now I get this

Style BACnet Value as a Graphic requires a row style but the row plugin is invalid.
Style BACnet Value as a Graphic requires a row style but the row plugin is invalid.
Style BACnet Trend Data requires a row style but the row plugin is invalid.
Style BACnet Trend Data requires a row style but the row plugin is invalid.
Style BACnet Trend Data requires a row style but the row plugin is invalid.
Style BACnet Trend Data requires a row style but the row plugin is invalid.
Style BACnet Trend Data requires a row style but the row plugin is invalid.
Style BACnet Trend Data requires a row style but the row plugin is invalid.
Style BACnet Trend Data requires a row style but the row plugin is invalid.
Style BACnet Trend Data requires a row style but the row plugin is invalid.

Guess I need to back out some of the changes.

Backed the the changes made to the class and uses_fields().

the format it liked is class "bacnet_plugin_row_bargraph" and "function uses_fields()". Coder wanted "BacnetPluginRowBargraph" and "function usesFields()"

Cleaned up most minor warnings on file bacnet_plugin_style_trend.inc .

Cleaned up most minor warnings on file BACNET_PLUGIN_STYLE_VALUEGRAPHIC.INC .

Cleaned up most minor warnings on file BACNET_PLUGIN_STYLE_VALUETEXT.INC

down to just a few at this pt

Coder found 1 projects, 18 files, 1 normal warnings, 80 minor warnings, 0 warnings were flagged to be ignored

Closing this because I think the only items left are being discussed under the False Positive issue here --> https://www.drupal.org/node/2324941

Opening back up to cleanup more Pareview issues introduced when implementing new features at #2337583: Supporting future BACnet standards

Adding unix style line endings reduced the number of preview issues down to just one, so closing out this issue again

https://www.drupal.org/node/2312955#comment-9149435