There are quite a few warnings currently at http://pareview.sh/pareview/httpgitdrupalorgsandboxdbt1022237027git

They are minor, but resolving these will help make more serious issues more obvious as the module matures and additional features are added.

Comments

dbt102’s picture

dbt102 commented

Fixed line endings on bacnet files.

Line endings on Flot files not messed with. Will take this library out of module and conner it in using library_api module at some point soon.

dbt102’s picture

dbt102 commented

Made several commits to begin cleanup of pareview errors and warnings. Loaded Coder module on local dev site for independent review. There were no Critical errors found in the code. Closing out this issue to focus specifically on Coder review warnings

dbt102’s picture

dbt102 commented
Status: Active » Closed (works as designed)
dbt102’s picture

dbt102 commented
Priority: Minor » Normal
Status: Closed (works as designed) » Closed (fixed)

I reduced the BACnet module down to core soap functionality for now to eliminate all pareview errors. I think many of the error that were being thrown was because of the views integration for the display of dials, graphs, charts and even text.

With a stable module release of the base BACnet module, we can then start adding the pieces back in to make sure that the best possible module is available to the community.