UrlGeneratorTrait::setUrlGenerator sets linkGenerator property instead of urlGenerator

Yups that's write. Thanks for the fix. Do we need phpunit for this?

Good catch!

The test should fail :(

RTBC if green

1. +++ b/core/lib/Drupal/Core/Routing/UrlGeneratorTrait.php
   @@ -62,7 +62,7 @@ protected function getUrlGenerator() {
       */
      public function setUrlGenerator(UrlGeneratorInterface $generator) {
   -    $this->linkGenerator = $generator;
   +    $this->urlGenerator = $generator;
    
        return $this;
      }
   

   If we write a test we should add a proper dedicated test for the trait (note there is a phpunit helper method to create a mock from a trait.

2. +++ b/core/tests/Drupal/Tests/Core/Controller/ControllerBaseTest.php
   @@ -58,4 +58,22 @@ public function testGetConfig() {
   +    $url_generator = $this->getMockBuilder('\Drupal\Core\Routing\UrlGeneratorInterface')
   +      ->disableOriginalConstructor()
   +      ->getMock();
   +
   

   you can just use getMock()

Thank you for updating the tests. Can you upload the test only patch?

1. +++ b/core/tests/Drupal/Tests/Core/Routing/UrlGeneratorTraitTest.php
   @@ -0,0 +1,34 @@
   + * Contains Drupal\Tests\Core\Routing\UrlGeneratorTraitTest.
   + */
   +
   +namespace Drupal\Tests\Core\Routing;
   +
   +use Drupal\Tests\UnitTestCase;
   

   cool!

2. +++ b/core/tests/Drupal/Tests/Core/Routing/UrlGeneratorTraitTest.php
   @@ -0,0 +1,34 @@
   + *
   + * @group Routing
   + */
   +class UrlGeneratorTraitTest extends UnitTestCase {
   +
   +  /**
   +   * Tests the urlGenerator method.
   +   */
   +  public function testGetUrlGenerator() {
   

   Let's use @coversDefaultClass and @covers

3. +++ b/core/tests/Drupal/Tests/Core/Routing/UrlGeneratorTraitTest.php
   @@ -0,0 +1,34 @@
   +    $url_generator = $this->getMockBuilder('\Drupal\Core\Routing\UrlGeneratorInterface')->getMock();
   

   you can use getMock('Drupal\Core\Routing\UrlGeneratorInterface'); directly.

New patch and test-only patch

Yay!! thank you for the test only patch.

Committed 8e6b32a and pushed to 8.0.x. Thanks!

diff --git a/core/lib/Drupal/Core/Routing/UrlGeneratorTrait.php b/core/lib/Drupal/Core/Routing/UrlGeneratorTrait.php
index ec0ba86..06d0445 100644
--- a/core/lib/Drupal/Core/Routing/UrlGeneratorTrait.php
+++ b/core/lib/Drupal/Core/Routing/UrlGeneratorTrait.php
@@ -1,15 +1,12 @@
 <?php
 
 /**
- * @file Contains Drupal\Core\Routing\UrlGeneratorTrait.
+ * @file
+ * Contains Drupal\Core\Routing\UrlGeneratorTrait.
  */
 
 namespace Drupal\Core\Routing;
 
-
-use Drupal\Core\Utility\LinkGeneratorInterface;
-use Drupal\Core\Routing\UrlGeneratorInterface;
-
 /**
  * Wrapper methods for the Url Generator.
  *

Minor fixes on commit.