CommentFileSizeAuthor
#3 2309301-3.patch1.52 KBwim leers

Comments

cs_shadow’s picture

cs_shadow commented
Status: Active » Postponed
Issue tags: +revisit before release

Postponing until we freeze features of the module, otherwise this'll also need to be updated with every PR.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Postponed » Active
Issue tags: - +revisit before release

d.o somehow ate this tag that @cs_shadow added in #1… strange!

Anyway, now that we're getting closer to a release, it probably makes sense to actually do this. I'll take a stab at it later this week, after I've gone through all of Entity Embed.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
Issue tags: -revisit before release
StatusFileSize
new 2309301-3.patch1.52 KB

Anyway, now that we're getting closer to a release, it probably makes sense to actually do this. I'll take a stab at it later this week, after I've gone through all of Entity Embed.

… I didn't end up having time back then to continue going through all of Entity Embed, but as irony would have it, I am right now! 😅😂

So, about 3 years late, here it is!

Status: Needs review » Needs work

The last submitted patch, 3: 2309301-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Documentation

I like it!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.