CommentFileSizeAuthor
#11 create_tabs_widget-2308173-11.patch5.31 KBneardark
#10 create_tabs_widget-2308173-10.patch1.11 KBneardark
#5 ebiframetab.png40.6 KBJayeshSolanki

Comments

slashrsm’s picture

slashrsm commented
Status: Active » Needs review
slashrsm’s picture

slashrsm commented
Status: Needs review » Needs work

Merged, but needs more work.

  • slashrsm committed b0c2c85 on 8.x-1.x 
    Issue #2308173 by slashrsm: Very basic implementation of widget selector...
  • slashrsm committed 420c570 on 8.x-1.x
    Issue #2308173 by slashrsm: Fix typo.
JayeshSolanki’s picture

JayeshSolanki commented
Component: Code » Core API
Status: Needs work » Needs review

New pr: https://github.com/drupal-media/entity_browser/pull/67

JayeshSolanki’s picture

JayeshSolanki commented
Issue summary: View changes
StatusFileSize
new ebiframetab.png40.6 KB

I was getting an error while trying to change widgets using tabs, it was the same as I reported in https://www.drupal.org/node/2495071 with dropdown plugin. So this above pull request was made by reverting to an old commit where dropdown plugin was working ok.

slashrsm’s picture

slashrsm commented
Issue summary: View changes
Status: Needs review » Needs work

Merged your PR as it looks ok. WE still need to fixthe issue from #5.

  • JayeshSolanki committed 501cc56 on 8.x-1.x 
    Issue #2308173: Implementation of tabs plugin using form element buttons...
  • slashrsm committed e63706c on 8.x-1.x
    Merge pull request #67 from jayeshsolanki93/Add-tabs-Widget-Selector...
slashrsm’s picture

slashrsm commented
Issue tags: +Media Initiative, +sprint
slashrsm’s picture

slashrsm commented
Issue tags: -sprint +D8Media
neardark’s picture

neardark commented
Status: Needs work » Needs review
StatusFileSize
new create_tabs_widget-2308173-10.patch1.11 KB

Disregard this patch.

neardark’s picture

neardark commented
StatusFileSize
new create_tabs_widget-2308173-11.patch5.31 KB

Suspect my workflow on here is wrong (should be using github?) but here's theming for the tabs.

slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Committed. Thanks!

  • slashrsm committed f92c687 on 8.x-1.x authored by neardark 
    Issue #2308173 by neardark: Create "Tabs" widget selector plugin

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.