While using the example module, I found that the dropdown plugin can no longer change the widget.
The ajax error received in response is:

{"message":"A fatal error occurred: Settings can not be serialized. This probably means you are serializing
 an object that has an indirect reference to the Settings object. Adjust your code so that is not necessary."}
CommentFileSizeAuthor
#9 entity_browser-widgetselector-fix-2495071-8.patch883 bytessamuel.mortenson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JayeshSolanki’s picture

JayeshSolanki CreditAttribution: JayeshSolanki commented
Issue summary: View changes
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented

I get this for any browser using a modal display.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented
Related issues: +#2502195: \Drupal\Core\StringTranslation\Translator\CustomStrings should be serializable, but contain \Drupal\Core\Site\Settings which is not
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented

Added possibly related core regression.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented
Priority: Normal » Major

Moving to Major as this seems to affect multiple features of the module and the related issue's patch doesn't fix this problem.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at Examiner.com commented
Issue tags: +Media Initiative, +sprint
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at Examiner.com commented
Issue tags: -sprint +D8Media
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented

After applying the patch from the related issue, I'm now getting

{"message":"A fatal error occurred: The database connection is not serializable. This probably means you are serializing an object that has an indirect reference to the database connection. Adjust your code so that is not necessary. Alternatively, look at DependencySerializationTrait as a temporary solution."}

Guessing that the Connection object is being added to the form somewhere.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented
FileSize
entity_browser-widgetselector-fix-2495071-8.patch883 bytes

It looks like the views display plugin "entity_browser" was adding the View to the render array before the form was cached, which caused the series of errors described in this issue. This patch moves the view to the elementPreRender method, which does not cache/serialize the View. No other patch is required, but I'll keep the related issue around for posterity.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented
Status: Active » Needs review
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented
Status: Needs review » Needs work

Making some changes and re-pulling...

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at Examiner.com commented

Is this patch still necessary after http://cgit.drupalcode.org/entity_browser/commit/?id=6c180b5b0cd4282a5a4...

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented
Status: Needs work » Closed (fixed)

Sorry @slashrsm, I didn't do my due-diligence and follow up on this issue. The dropdown seems to be working fine, so I'm closing this out. Thanks!