Follow-up to #1962846-44: Use field instance name for header of comment list, drop comment-wrapper template which added:

+++ b/core/modules/comment/comment.module
@@ -134,9 +134,9 @@ function comment_theme() {
+    'field__comment' => array(
+      'base hook' => 'field',
+      'template' => 'field--comment',
     ),

We shouldn't have to explicitly define something that should be detected automatically when the theme registry is built.

Comments

mgifford’s picture

Status: Postponed » Active

Beta1 seems like a good time to remove this.. Or close this issue.

balagan’s picture

Status: Active » Postponed

Changing status to postponed, until the parent issue is fixed Specific preprocess functions for theme hook suggestions are not invoked

mgifford’s picture

Status: Postponed » Active

That's fixed now.

andypost’s picture

Version: 8.0.x-dev » 8.1.x-dev

Suppose that allowed only in 8.1 branch with CR

andypost’s picture

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

Status: Active » Needs review
FileSize
1.99 KB

Guess it should work now

Status: Needs review » Needs work

The last submitted patch, 9: 2307103-comment-field-preprocess-9.patch, failed testing.