Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
19 Jul 2014 at 21:41 UTC
Updated:
3 Oct 2014 at 10:25 UTC
Jump to comment: Most recent
Comments
Comment #1
carlwillimott commentedComment #2
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxcarlwillimott2301839git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
gislePre-review notes:
Comment #4
abogomolov commentedHi carlwillimott,
applying the first module is realy hard. Here are some issues I found:
See https://www.drupal.org/node/542202
$folders = variable_get('clearout_folders') ? variable_get('clearout_folders') : false;You can pass the default value to variable_get() as second parameter.
$folders = variable_get('clearout_folders', false)Same in file_clearout()
Comment #5
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.