This module is intended for drupal 7.x. [D7]

It is titled: 'Clearout'.

It provides simple functionality for deleting files from specified public folders at certain intervals. Please see the project page for more information.

https://www.drupal.org/sandbox/carlwillimott/2301839

git clone --branch 7.x-1.x carlwillimott@git.drupal.org:sandbox/carlwillimott/2301839.git clearout
cd clearout

Comments

carlwillimott’s picture

Issue summary: View changes
Status: Active » Needs review
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxcarlwillimott2301839git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

gisle’s picture

Pre-review notes:

Issue form
Your issue form title is non-standard. See https://www.drupal.org/node/1011698 for correct format.
Git Clone Command
No. Your git clone command contains your username and is for you only. It will not allow others to clone your project. Please see https://www.drupal.org/node/1011698 for instructions on finding the correct format.
Project page
No. Please take a moment to make your project page follow the Project page template and it may be a good idea to also read tips for a great project page.
README
No, missing. Make sure your README-file follow the guidelines for in-project documentation and the README Template.
abogomolov’s picture

Hi carlwillimott,

applying the first module is realy hard. Here are some issues I found:

  • clearout.info ist not correct. (Missing description, code, package)
    See https://www.drupal.org/node/542202
  • hook_menu() defaults to MENU_NORMAL_ITEM so defining a type is not necessary.
  • $folders = variable_get('clearout_folders') ? variable_get('clearout_folders') : false;
    You can pass the default value to variable_get() as second parameter.
    $folders = variable_get('clearout_folders', false)
    Same in file_clearout()
  • All your function should be prefixed with the module name. (See file_clearout())
  • file_clearout(): Use filesystem fron Drupal for operations. (See https://api.drupal.org/api/drupal/includes%21file.inc/7)
  • Unused function create_random_files()
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.