MenuLinkContent disabled field should be renamed to enabled and use positive logic

This should fix MenuTreeStorageTest.

A few more fixes... but I have to stop for now.

+++ b/core/lib/Drupal/Core/Menu/Form/MenuLinkDefaultForm.php
@@ -124,7 +124,7 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta
+      '#default_value' => $this->menuLink->isEnabled(),

I wonder whether we considered to use status? At least this is what config entities and node use.

From at least #4 on there is a regression that displays the filter tips menu to anonymous users. It is this path:

filter.tips_all:
  path: '/filter/tips'
  defaults:
    _content: '\Drupal\filter\Controller\FilterController::filterTips'
    _title: 'Compose tips'
  requirements:
    _access: 'TRUE'

Renamed MenuTreeParameters::onyEnabledLinks to onlyEnabledLinks. I assume that was a typo.

@pwolanin - yet there it is. Test it manually and see what I mean.

Fixed the failures as well as the problem mentioned by @cliefen.

On top of that I had a quick scan through the patch and could not find anything problematic.

I just fixed a tiny little detail of the tests.

This is a huge improvement because having to revert the logic all over the place is just a bad idea in general and could lead
easily to problems.

Needs a reroll

 git ac https://www.drupal.org/files/issues/2305707-29.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 38984  100 38984    0     0  61153      0 --:--:-- --:--:-- --:--:-- 66753
error: patch failed: core/modules/system/src/Tests/Menu/MenuTreeStorageTest.php:311
error: core/modules/system/src/Tests/Menu/MenuTreeStorageTest.php: patch does not apply

Rerolled.

Rerolled. FieldDefinition => baseFieldDefinition.

Committed 4ae3ee3 and pushed to 8.0.x. Thanks!

diff --git a/core/tests/Drupal/Tests/Core/Menu/MenuTreeParametersTest.php b/core/tests/Drupal/Tests/Core/Menu/MenuTreeParametersTest.php
index d2add36..4222541 100644
--- a/core/tests/Drupal/Tests/Core/Menu/MenuTreeParametersTest.php
+++ b/core/tests/Drupal/Tests/Core/Menu/MenuTreeParametersTest.php
@@ -119,7 +119,7 @@ public function testAddCondition() {
    *
    * @covers ::onlyEnabledLinks
    */
-  public function testExcludeDisabledLinks() {
+  public function testOnlyEnabledLinks() {
     $parameters = new MenuTreeParameters();
     $parameters->onlyEnabledLinks();
     $this->assertEquals(1, $parameters->conditions['enabled']);

Change test method name on commit.