The module uses the inlineDisqussions jQuery plugin developed by tsi(https://www.drupal.org/user/322980) and provides a basic interface for administrators to set plugin options.
inlineDisqussions is a jQuery plugin to allow inline comments on your site.
Comments threads are created with the power of the awesome (and free) Disqus, they are created dynamically and attached to the specific sections (paragraph, usually, but not necessarily) of your post. The original use-case was naturally a blog post so you could comment next to each paragraph, but you could use this to have comment threads on every section of any web page - think of commenting on every product in a one-page catalog, on each picture in a photo gallery etc.
Project Page
https://www.drupal.org/sandbox/kamescg/2305395
Git Clone Link
http://git.drupal.org/sandbox/kamescg/2305395.git
PA Review
http://pareview.sh/pareview/httpgitdrupalorgsandboxkamescg2305395git
| Comment | File | Size | Author |
|---|---|---|---|
| documents.png | 5.9 KB | kamescg |
Comments
Comment #1
kamescg commentedComment #2
kamescg commentedComment #3
kamescg commentedAdd PareView link
Comment #4
kamescg commentedComment #5
kamescg commentedI need help solving these errors...
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
21 | WARNING | Code after RETURN statement cannot be executed
190 | ERROR | Concat operator must be surrounded by spaces
--------------------------------------------------------------------------------
Comment #6
skh commentedHi again, nice work on getting most of the issues resolved! Here's some tips on your remaining ones:
On line 21 you have a return statement. Afterwards, you have a break, which is the code that 'will not get executed'. When doing a switch statement, you'll usually put the return statement after the closing bracket of the switch statement. That way if you have multiple cases, you only need to have the one return. Try moving the return statement just after the close of the switch block.
On line 189, you need to have a space on both sides of the equals sign
$inline_code ='d...should be$inline_code = 'd...See the operators section on the coding standards for more.Line 190 is the same issue as above, but you need spaces surrounding the '.' when joining the string together.
Once you get those fixed up, set to "Needs Review" and someone will do a manual review of the code. When it's set to "Needs work" people won't really see any questions you post.
Also, FYI, it's PA Review (for project application review). Not a Pare :)
Comment #7
kamescg commentedskh you're the man!
Thanks for all your help the other day in the IRC channel. I really appreciate you taking the time to walk me through the process.
I am going to clean up the rest of the code tonight and try and get the module back into "Needs Review" categorization.
Comment #8
kamescg commentedFixed PA Review
Comment #9
kamescg commentedPA Review problems have been addressed and need to review the module now.
Thanks everyone! :)
Comment #10
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #11
guilopes commented1 - Change module page to Inline Disqussions, and change in .info file name to Inline Disqussions, because your module use inline_disqussions files.
2 - Resolve git conflicts in README.txt.
3 - In jquery.inlineDisqussions.js add Drupal.behaviors
Comment #12
guilopes commentedComment #13
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.