Both the "Aggregated fields" and "Highlight" processors internally use Utility::extractFields() in some cases to get the values of fields that weren't extracted already. However, these calls are currently untested since it's a bit more complicated to mock correctly. Still, we should make sure that the method is correctly called (and its return value correctly used) there, too.
Estimated Value and Story Points
This issue was identified as a Beta Blocker for Drupal 8. We sat down and figured out the value proposition and amount of work (story points) for this issue.
Value and Story points are in the scale of fibonacci. Our minimum is 1, our maximum is 21. The higher, the more value or work a certain issue has.
Value : 1
Story Points: 5
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 2305021-13--processor_field_extraction_tests.patch | 32.89 KB | drunken monkey |
Comments
Comment #1
drunken monkeyComment #2
nick_vhComment #3
drunken monkeyThis contains tests for both the "Highlight" and the "Aggregated field" processor and also fixes #2703915: Empty highlighted excerpt due to missing datasource ID.
Comment #4
drunken monkeyComment #5
borisson_Only nitpicks, overall this look good, I'll have another look tomorrow, when I'm not as tired.
An array of items, so to be clear in the description that this is an actual array?Can we rename this? At least $return, but preferrably to $extracted_values?
can we add a newline here? for reability?
Field/property value is not present on the item. Skip this item if we don't want to load it.Comment #6
drunken monkeyAh, I've missed your nitpicks! Good, to have you back! ;)
I think the type specification makes that clear enough.
The other three should be fixed in the attached patch – though the last one was really hard to phrase well.
Comment #7
borisson_Comment #9
drunken monkeyCommitted.
Thanks!
Comment #10
drunken monkeyThis broke tests (or those tests added here were broken afterwards – still, this is as good a place as any to fix them).
Comment #12
drunken monkeyCommitted the revert.
Comment #13
drunken monkeyFound it!
Conflict with #2752749: Make handling of index plugins/fields consistent.
Comment #15
drunken monkeyCommitted.