Block titles are too dark in footer column regions by default. It makes footer look a bit broken.

I suggest we change title to use the same color used for block content, here’s a screenshot demonstrating the change: https://www.evernote.com/shard/s13/sh/4e3235dc-0b65-4eee-8e16-986ac5e69b...

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

paulihuhtiniemi’s picture

Here’s a patch that changes block title color to same one used in #footer-wrapper .block .content

mgifford’s picture

Issue tags: +Accessibility, +color contrast

Thanks for this @paulihuhtiniemi

mgifford’s picture

Isn't that still over-ridden by:

#footer .block > h2 {
    clip: rect(1px, 1px, 1px, 1px);
    height: 1px;
    overflow: hidden;
    position: absolute !important;
}

I don't see the headings at all. Also, the color contrast isn't sufficient. A good tool to test is http://webaim.org/resources/contrastchecker/

Also - http://contrast-finder.tanaguru.com

jhedstrom’s picture

Status: Needs review » Needs work

Needs work per #3 I think.

emma.maria’s picture

Category: Task » Bug report
Priority: Minor » Normal

This issue is currently blocked by the h2's being hidden in the footer #2148319: h2 on footer blocks must be hidden by default but must show when its enable.
The block titles in the footer need to be brought back then their accessibility can be worked on.

Also setting this issue to be a bug and a normal priority as the heading colour's do not pass contrast tests.

emma.maria’s picture

We should work on #2148319: h2 on footer blocks must be hidden by default but must show when its enable I believe that issue should be fixed and then we can come back to this :)

emma.maria’s picture

Title: Change default block title color in footer columns to improve contrast » Change default block title colors in Footer first to fourth regions to improve contrast
Status: Postponed » Active

This issue is just for the titles in the footer first to fourth regions.
Un-postponing this issue for a new patch.
The patch in #1 is incorrect but the work suggested in the comment is what we need to do?! Let's create a new patch changing the titles to be the same colour as the content in footer first - fourth regions.

Chloe Chen’s picture

updated footer region one to four title color to be #ffffff, to increase contrast and differ from link color

crazyrohila’s picture

Status: Needs review » Active

I think this should be covered in https://www.drupal.org/node/2148319#comment-9719693

we can tackle both issue separately.

idebr’s picture

Status: Active » Needs work

@Chloe Chen Thanks for working on this!

  1. +++ b/core/themes/bartik/css/components/footer.css
    @@ -8,6 +8,9 @@
    +#site-footer__wrapper h2{  ¶
    

    There are some trailing spaces here. Can you check your editor configuration to remove white spaces at the end of each line?

  2. +++ b/core/themes/bartik/css/components/footer.css
    @@ -8,6 +8,9 @@
    +  color: #ffffff;
    

    Drupal CSS coding standards suggest using shorthand colors when possible, eg. use '#fff' instead of '#ffffff'.

idebr’s picture

Issue tags: +CSS
crazyrohila’s picture

This one will get fixed in https://www.drupal.org/node/2148319. All the patches are resolving block header visibility issue in that issue.

mgifford’s picture

Ok, so #2148319: h2 on footer blocks must be hidden by default but must show when its enable is in now. Can wee verify that this problem is resolved before we mar this as a duplicate?

idebr’s picture

@mgifford The patch in the related issue was about displaying the title in the region 'Footer fifth', while this issue is about the contrast of the titles in regions 'Footer first' to 'Footer fourth'. So while related, they are actually separate issues.

prateekMehta’s picture

Making changes to @Chloe's patch as suggested in #10.

prateekMehta’s picture

Status: Needs work » Needs review
crazyrohila’s picture

This issue has been resolved in #2148319: h2 on footer blocks must be hidden by default but must show when its enable. Now all block title of footer-top and footer-bottom has same color as content.
Attached screenshot.

Before
Before patch

After
After patch

crazyrohila’s picture

Status: Needs review » Closed (duplicate)
crazyrohila’s picture

Status: Closed (duplicate) » Fixed

Changing status to Fixed.

emma.maria’s picture

Status: Fixed » Closed (duplicate)

This issue needs to stay as Closed (duplicate) as it's work was never committed to core.