Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Block titles are too dark in footer column regions by default. It makes footer look a bit broken.
I suggest we change title to use the same color used for block content, here’s a screenshot demonstrating the change: https://www.evernote.com/shard/s13/sh/4e3235dc-0b65-4eee-8e16-986ac5e69b...
Comments
Comment #1
paulihuhtiniemi CreditAttribution: paulihuhtiniemi commentedHere’s a patch that changes block title color to same one used in #footer-wrapper .block .content
Comment #2
mgiffordThanks for this @paulihuhtiniemi
Comment #3
mgiffordIsn't that still over-ridden by:
I don't see the headings at all. Also, the color contrast isn't sufficient. A good tool to test is http://webaim.org/resources/contrastchecker/
Also - http://contrast-finder.tanaguru.com
Comment #4
jhedstromNeeds work per #3 I think.
Comment #5
emma.mariaThis issue is currently blocked by the h2's being hidden in the footer #2148319: h2 on footer blocks must be hidden by default but must show when its enable.
The block titles in the footer need to be brought back then their accessibility can be worked on.
Also setting this issue to be a bug and a normal priority as the heading colour's do not pass contrast tests.
Comment #6
emma.mariaWe should work on #2148319: h2 on footer blocks must be hidden by default but must show when its enable I believe that issue should be fixed and then we can come back to this :)
Comment #7
emma.mariaThis issue is just for the titles in the footer first to fourth regions.
Un-postponing this issue for a new patch.
The patch in #1 is incorrect but the work suggested in the comment is what we need to do?! Let's create a new patch changing the titles to be the same colour as the content in footer first - fourth regions.
Comment #8
Chloe Chen CreditAttribution: Chloe Chen commentedupdated footer region one to four title color to be #ffffff, to increase contrast and differ from link color
Comment #9
crazyrohila CreditAttribution: crazyrohila commentedI think this should be covered in https://www.drupal.org/node/2148319#comment-9719693we can tackle both issue separately.
Comment #10
idebr CreditAttribution: idebr commented@Chloe Chen Thanks for working on this!
There are some trailing spaces here. Can you check your editor configuration to remove white spaces at the end of each line?
Drupal CSS coding standards suggest using shorthand colors when possible, eg. use '#fff' instead of '#ffffff'.
Comment #11
idebr CreditAttribution: idebr commentedComment #12
crazyrohila CreditAttribution: crazyrohila commentedThis one will get fixed in https://www.drupal.org/node/2148319. All the patches are resolving block header visibility issue in that issue.
Comment #13
mgiffordOk, so #2148319: h2 on footer blocks must be hidden by default but must show when its enable is in now. Can wee verify that this problem is resolved before we mar this as a duplicate?
Comment #14
idebr CreditAttribution: idebr commented@mgifford The patch in the related issue was about displaying the title in the region 'Footer fifth', while this issue is about the contrast of the titles in regions 'Footer first' to 'Footer fourth'. So while related, they are actually separate issues.
Comment #15
prateekMehta CreditAttribution: prateekMehta commentedMaking changes to @Chloe's patch as suggested in #10.
Comment #16
prateekMehta CreditAttribution: prateekMehta commentedComment #17
crazyrohila CreditAttribution: crazyrohila commentedThis issue has been resolved in #2148319: h2 on footer blocks must be hidden by default but must show when its enable. Now all block title of footer-top and footer-bottom has same color as content.
Attached screenshot.
Before
After
Comment #18
crazyrohila CreditAttribution: crazyrohila commentedComment #19
crazyrohila CreditAttribution: crazyrohila commentedChanging status to Fixed.
Comment #20
emma.mariaThis issue needs to stay as Closed (duplicate) as it's work was never committed to core.