Problem/Motivation

#2298319: views.display.block.allow should be a sequence not a boolean pointed out that we lose the dependency on the module that provides the table/entity because the entity schema is now generated and drupal_get_schema() is not able to find it.

Proposed resolution

Rely on the entity type to add the dependency and/or maybe the module providing the views_data integration if that info is available.

Possibly move this part into the query plugin, because a search_api view depends on the search_index that it queries, not a table or entity_type.

Remaining tasks

User interface changes

API changes

Files: 
CommentFileSizeAuthor
#7 interdiff.txt9.5 KBdawehner
#7 views-dependencies-2304479-7.patch21.74 KBdawehner
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 76,158 pass(es), 11 fail(s), and 24 exception(s). View
#4 2304479.patch12.21 KBdawehner
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2304479.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

catch’s picture

Issue tags: +D8 upgrade path, +beta target

Requires updating this for shipped configuration so adding upgrade path tag.

dawehner’s picture

Added the mentioned info in the todo.

damiankloip’s picture

dawehner’s picture

FileSize
12.21 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2304479.patch. Unable to apply patch. See the log in the details link for more information. View

This at least adds the provider onto the views data automatically. This could improve quite some bits now as it allows you to bypass

dawehner’s picture

Status: Active » Needs review

.

Status: Needs review » Needs work

The last submitted patch, 4: 2304479.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
Issue tags: +VDC
FileSize
21.74 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 76,158 pass(es), 11 fail(s), and 24 exception(s). View
9.5 KB

Let's have better code paths in case we know the provider already directly.

Add missing tag.

Status: Needs review » Needs work

The last submitted patch, 7: views-dependencies-2304479-7.patch, failed testing.

damiankloip’s picture

Status: Needs work » Closed (duplicate)

As discussed with dawehner, closing in favour of #2267453: Views plugins do not store additional dependencies