views.display.block.allow should be a sequence not a boolean

This should be pretty easy patchable.

Actually it should be a mapping I think? list is for a numbered list of the same sub-items, those are key/value pairs.

I don't know if this is pluggable, but I'd start with hardcoding the known example.

Here's a quick patch, @dawehner, are there any other per-block override things that we need to care about?

No, core is not written in a flexible way, on purpose.

+++ b/core/modules/block/config/schema/block.views.schema.yml
+++ b/core/modules/block/config/schema/block.views.schema.yml
@@ -18,5 +18,9 @@ views.display.block:

While you are in this file, can you remove the entry about block caching? This got removed in some other issue

Not pluggable sounds good :)

Sure, removed that.

Thank you.

Seems like this is an indication of missing test coverage

Most of our schema test coverage is implicit by testing our default configuration, so I simply updated the comments_recent default value and added that setting, as it was enabled but not properly exported.

With this, the install fails. The default view is a bit different, but I just openend it, resaved it and then added the setting manualy (because tryiyng to save it gives you an exception now).

@dawehner: Hm, are the additional options real or are they just there because I resaved the old view?

Ok, let's see how this goes.

We'd have to re-save all the views to figure out if there's more we're missing, but that seems to be too much for this issue?

We'd have to re-save all the views to figure out if there's more we're missing, but that seems to be too much for this issue?

Totally, opened a follow up for that: #2303409: Resave all the views.

back to rtbc

+++ b/core/modules/comment/config/install/views.view.comments_recent.yml
@@ -1,8 +1,14 @@
+dependencies: {  }

@@ -228,11 +236,7 @@ display:
-dependencies:
-  module:
-    - comment

Interesting... seems like we have a bug here.

Opened a separate bug report for that: #2304479: Dependency on entity-type providing module missing in views

Re-added the dependency manually for now. This won't really help as the imported view is re-saved and dependencies are re-calculated (I think this is wrong but that's yet another topic)

interdiff was correct but patch was the previous one.. :(

I think it's OK if set this back to RTBC myself, it was before, just made the small manual change that doesn't actually affect anything as it's not persisted nor checked (with and without this issue, already equally broken in HEAD).

Committed 518e3c9 and pushed to 8.x. Thanks!

diff --git a/core/modules/block/config/schema/block.views.schema.yml b/core/modules/block/config/schema/block.views.schema.yml
index 425c64e..53affeb 100644
--- a/core/modules/block/config/schema/block.views.schema.yml
+++ b/core/modules/block/config/schema/block.views.schema.yml
@@ -20,4 +20,4 @@ views.display.block:
       mapping:
         items_per_page:
          type: boolean
-         label: Items per page
+         label: 'Items per page'

Fixed on commit.