Problem/Motivation

This is the followup issue to #2291137: Rename various *links.yml files to improve DX.

The change record.

CommentFileSizeAuthor
#2 2303605-2.patch10.06 KBcilefen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Assigned: Unassigned » cilefen
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2303605-2.patch10.06 KB
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue tags: +DX
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Postponed
Issue tags: -DX +DX (Developer Experience)

Postponed on #2256521: [META] New plan, Phase 2: Implement menu links as plugins, including static admin links and views, and custom links with menu_link_content entity, all managed via menu_ui module.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented

Does this really need to be postponed on all 5 parts of the menu link conversion? #2301239: MenuLinkNG part1 (no UI or conversions): plugins (static + MenuLinkContent) + MenuLinkManager + MenuTreeStorage already landed, and I don't think this patch conflicts with any of the other parts.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Postponed » Active

Ah! If it doesn't conflict with the rest of the patches, then by all means.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented
Status: Active » Needs review

Cool. Back to needs review then. On dreditor inspection, patch looks good to me, but I haven't checked if it's complete or reviewed the change record, so leaving to others to RTBC.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#2304067: Adapt menu alter hooks to the new filenames

There aren't other menu links left:

$ find . -name "*menu_links.yml"
./modules/webprofiler/webprofiler.menu_links.yml
$ git grep "menu_links.yml" .

One thing we should talk about in a follow up, the hook names no longer match the file names at all:

  • hook_menu_link_defaults_alter
  • hook_menu_local_tasks_alter
  • hook_menu_local_actions_alter
  • hook_contextual_links_alter

See #2304067: Adapt menu alter hooks to the new filenames

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed b560f34 and pushed to 8.x. Thanks!

  • alexpott committed b560f34 on 8.x 
    Issue #2303605 by cilefen: Rename *.menu_links.yml to *.links.menu.yml...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.