When I use the filter I don't get the full screen button. Doesn't seems like it is a attribute for it. How can I get it?

CommentFileSizeAuthor
#9 video_filter-fix_html5_fullscreen-2302669-9.patch791 bytesshaundychko
#4 video_filter-fix_html5_fullscreen-2302669-4.patch727 bytesjox

Comments

silkogelman’s picture

silkogelman commented

For this to work according to YouTube docs the final embed url should get &fs=1 appended to it.
source: https://developers.google.com/youtube/player_parameters#controls

silkogelman’s picture

silkogelman commented

It seems to be enabled and working for the Flash version,
default HTML5 version doesn't get &fs=1 appended and doesn't show the button.
HTML5 should work when &fs=1 is appended to the embed code url according to the Youtube docs.

Temporary workaround: use the Flash version.
Enable by editing the video_filter settings in the text format settings.

silkogelman’s picture

silkogelman commented

Even if I patch the module and make it add the &fs=1 to the embed url, it doesn't seem to display the button.
However if I then copy paste the same url to a new browser tab, it does display the button.

May have to do with the iframe. not sure.

jox’s picture

jox commented
Status: Active » Needs review
StatusFileSize
new video_filter-fix_html5_fullscreen-2302669-4.patch727 bytes

I fixed it for HTML5 by adding allowfullscreen="1" to the iframe. No other change was needed. The cache has to be flushed afterwards to take effect.

Attaching a patch.

grn’s picture

grn commented
Status: Needs review » Reviewed & tested by the community

Great jox! It works like a charm.

Changing status.

BR. GrN.dk

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2297491: Plan for Video Filter v7.x-3.2 release

This should be added to the next release.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-3.1 » 7.x-3.x-dev
blackdog’s picture

blackdog commented
Status: Reviewed & tested by the community » Closed (fixed)
shaundychko’s picture

shaundychko
Location Vancouver, Canada
commented
Category: Support request » Feature request
Status: Closed (fixed) » Needs review
StatusFileSize
new video_filter-fix_html5_fullscreen-2302669-9.patch791 bytes

Rerolled #4 against the latest 7.x-3.x of video_filter. #4 no longer applies since the iframe was wrapped in a div.video-filter.

minnur’s picture

minnur commented

This has been fixed in D8 version. If I have time I can add this D7 version.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Closed (duplicate)
Parent issue: #2297491: Plan for Video Filter v7.x-3.2 release »

This was resolved via #2577779: Show fullscreen button disabled in iframe for Youtube videos .