As a follow-up on #2265631: Upgrade phpFlickr to version 3.1.1 it would be good to use the libraries module to place the phpFlickr library outside of the module and load it as a library. This would make updating the library easier.

I'm working on a patch.

CommentFileSizeAuthor
#2 flickrapi-put_library_in_sites_all_libraries-2301991-2.patch106.01 KBmarty2081

Comments

marty2081’s picture

marty2081 commented
Issue summary: View changes
Related issues: +#2265631: Upgrade phpFlickr to version 3.1.1

Removed link to 6.x issue

marty2081’s picture

marty2081 commented
Status: Active » Needs review
StatusFileSize
new flickrapi-put_library_in_sites_all_libraries-2301991-2.patch106.01 KB

And here is a patch. The module now depends on the libraries module to be able to use a PHP library from sites/all/libraries. Since there is no version number in the phpFlickr library whatsoever I set the version to 'No version' in the hook_libraries_info() implementatiion.

BarisW’s picture

BarisW commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch @Marty2018. I'm happy to commit this (works great), except that we need to test contrib modules too.
I just tested flickrgallery, and I see that it has hard dependencies to the phpFlickr object (argh).

So although RTBC, I can't commit this just yet.

marty2081’s picture

marty2081 commented

Can't you create a new release and contact the maintainer of the flickrgallery module (or create an issue in the project issue queue) that there has been a change to the module that requires him/her to use libraries_load('phpFLickr') before using the phpFlickr class to be able to continue using the flickrapi library?

Or you can commit it to the dev version and give him/her some time to update the flickrgallery module so that you can both release a stable version with the change at te same time...

  • BarisW committed 15fc450 on 7.x-1.x authored by Marty2081 
    Issue #2301991 by Marty2081: Put phpFlickr library in sites/all/...
BarisW’s picture

BarisW commented

Agreed, just committed the change to DEV. Let's add an issue in the flickrgallery module.

tangent’s picture

tangent commented

I was thinking that such a change would require a new version (2.x?) because those who upgrade without reading the changelog will be surprised to discover that the module no longer works.

marty2081’s picture

marty2081 commented

People should read the release notes before upgrading... ;) But yeah, strictly speaking a new 7.x-2.x branch would be in order.

donnycarette’s picture

donnycarette commented

Flickrgallery 7.x-3.0-beta1 version is released to work with the flickrapi dev version and supports the libraries integration

  • BarisW committed 15fc450 on 7.x-2.x authored by Marty2081 
    Issue #2301991 by Marty2081: Put phpFlickr library in sites/all/...
BarisW’s picture

BarisW commented
Status: Reviewed & tested by the community » Fixed

And we have a 2.0 branch. Thanks for all the work!

https://www.drupal.org/node/2456365

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.