Fields value are always saved for default language, regardless of the value selected in the language selector.

Gave this patch a quick run in an existing project install yesterday and found that I was having issues with creating new fieldable panels panes from the page manager UI (via modal window) afterwards. I'll try to set up a cleaner environment to try this in to see if I can track down what was going on a bit more (since it looks like in my case it was something getting twisted up between FPP, WYSIWYG/IMCE and this).

Essentially I could choose to add a pane, find my pane type, fill out the form, but when clicking submit it would keep the Ajax indicator/spinner indefinitely and not complete the process of saving the entity. Based on the log messages and some quick googling it could be an interaction between what's going on here when combined with long text fields that use WYSIWYG/IMCE.

Hello,

it seems to be the the same issue I have if creating a new book page (book module enabled) or create a new child book page. In the entity translation configuration page I have set "German" as default language, but in every case the form page for the new book page shows "language neutral". There is no effect if changing the value in the form if this is the first save of the book page. If I open the page again and change the language - the second save, saves the right language.

This patch (#6) here based on the DEV (7.x-1.0-beta3+13-dev) does not solve my problem!

Matroschker

I have the same issue with Fieldable panel panes + Entity Translation + Field collection, and it seems that sending the complete form as an argument is not enough, because certain validation callbacks (for widgets) still use the old LANGUAGE_NONE to access the form structure, but the values have already been moved to the appropriate language.
Specifically I have this problem in field_collection_field_widget_embed_validate().
I am still not sure what is the proper solution.

So I was able to shoehorn Entity Translation + FPP + Field Collection, with some serious dirty code, hacks and duct tape, to actually kinda work, and save field data values with the proper selected Language on Entity creation.

I hardcoded the bit that I needed into the FPP module method EntityTranslationFieldablePanelsPaneHandler::entityFormLanguageWidgetSubmit(). But it should theoretically work by adding the same code into the default EntityTranslationDefaultHandler

/**
   * @see EntityTranslationHandlerInterface::entityFormLanguageWidgetSubmit()
   */
  public function entityFormLanguageWidgetSubmit($form, &$form_state) {
    $this->updateFormLanguage($form_state);
    $form_langcode = $this->getFormLanguage();

    $complete_form = &$form_state['complete form'];

    foreach (field_info_instances($this->entityType, $this->bundle) as $instance) {
      $field_name = $instance['field_name'];
      if (isset($complete_form[$field_name]['#language'])) {
        $field = field_info_field($field_name);
        $previous_langcode = $complete_form[$field_name]['#language'];

        // Handle a possible language change: new language values are inserted,
        // previous ones are deleted.
        if ($field['translatable'] && $previous_langcode != $form_langcode && isset($form_state['values'][$field_name][$previous_langcode])) {
          $form_state['values'][$field_name][$form_langcode] = $form_state['values'][$field_name][$previous_langcode];
          $form_state['values'][$field_name][$previous_langcode] = array();

          // Fix the field data language code, and array parents stored in the
          // $form_state.
          if (isset($form_state['field'][$field_name][$previous_langcode])) {
            // Move lang code.
            $form_state['field'][$field_name][$form_langcode] = $form_state['field'][$field_name][$previous_langcode];
            unset($form_state['field'][$field_name][$previous_langcode]);

            // Fix array parents.
            $field_array_parents = &$form_state['field'][$field_name][$form_langcode]['array_parents'];
            if ($field_array_parents[1] == LANGUAGE_NONE) {
              $field_array_parents[1] = $form_langcode;
            }
          }

          // Fix the forms language codes.
          if (isset($complete_form[$field_name][$previous_langcode])) {
            // Move data to another language code in form.
            $complete_form[$field_name]['#language'] = $form_langcode;
            $complete_form[$field_name][$form_langcode] = $complete_form[$field_name][$previous_langcode];
            unset($complete_form[$field_name][$previous_langcode]);

            // Fix language code first level.
            $complete_form[$field_name][$form_langcode]['#language'] = $form_langcode;

            // Fix the array parents.
            $complete_form[$field_name][$form_langcode]['#parents'] = $complete_form[$field_name][$form_langcode]['#tree'] && $complete_form[$field_name]['#tree'] ? array_merge($complete_form[$field_name]['#parents'], array($form_langcode)) : array($form_langcode);
            // Ensure #array_parents follows the actual form structure.
            $array_parents = $complete_form[$field_name]['#array_parents'];
            $array_parents[] = $form_langcode;
            $complete_form[$field_name][$form_langcode]['#array_parents'] = $array_parents;

            // For each delta item.
            foreach (element_children($complete_form[$field_name][$form_langcode]) as $delta_key) {
              if (isset($complete_form[$field_name][$form_langcode][$delta_key]['#language'])) {
                // Fix second level language code.
                $complete_form[$field_name][$form_langcode][$delta_key]['#language'] = $form_langcode;

                // Fix array parents.
                $complete_form[$field_name][$form_langcode][$delta_key]['#parents'] = $complete_form[$field_name][$form_langcode][$delta_key]['#tree'] && $complete_form[$field_name][$form_langcode]['#tree'] ? array_merge($complete_form[$field_name][$form_langcode]['#parents'], array($delta_key)) : array($delta_key);
                // Ensure #array_parents follows the actual form structure.
                $array_parents = $complete_form[$field_name][$form_langcode]['#array_parents'];
                $array_parents[] = $delta_key;
                $complete_form[$field_name][$form_langcode][$delta_key]['#array_parents'] = $array_parents;
              }
            }
          }
        }
      }
    }
  }

The gist of it, is that when we move the field values from one $lang_code to another inside $form_state, we need to do some cleanup in the $form as well.
For example we need to change all LANGUAGE_NONE's into 'en' in the field container hierarchy, we have to fix the array parents, we have to do the same in the special $form_state['field'] storage.

This is dirty, unmaintainable, but it worked for my test use-cases, so I can only assume that something along these lines should be done to make it work.

See #18 in https://www.drupal.org/node/1669494 for a possible workaround.

@mongolito I might check out your sandbox on a new project, and leave some feedback.

Indeed your patch has been committed and it seems to work now.
Related to FPPs / FCs, I've tested it one more time, and it seems to be working properly (haven't done extensive testing), with the latest patch in #1344672: Field Collection: Field translation (entity_translation) support..

So I guess the issue can be marked as fixed.

@mongolito404:

Thanks for the beautiful bug report and sorry it took me so long to get to it. I followed the steps to reproduce the issue and it seems f4df0047 actually fixed it, so marking this as a duplicate.

I updated the change log to credit you too for the solution :)