[D7] Digital Publications

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxluizhcanetfilho228128...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

luizhcanetfilho,

You may want to perform some cleanup by running your code through CodeSniffer first:
https://www.drupal.org/node/1419988

batch_pages.inc
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
4 | ERROR | The third line in the file doc comment must contain a description
| | and must not be indented
82 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------

composer.json
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
6 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

digital_publications.install
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
4 | ERROR | The third line in the file doc comment must contain a description
| | and must not be indented
--------------------------------------------------------------------------------

digital_publications.module
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
4 | ERROR | The third line in the file doc comment must contain a description
| | and must not be indented
--------------------------------------------------------------------------------

Also, you may want to change your git clone instructions to:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/luizhcanetfilho/2281287.git
instead of git clone --branch 7.x-1.x luizhcanetfilho@git.drupal.org:sandbox/luizhcanetfilho/2281287.git
for everyone's convenience.

I'll be happy to continue reviewing once these issues are cleaned up. Good luck.
Rob

Hi luizhcanetfilho,

I noticed that you use the Booklet JQuery plugin which you correctly call in the libraries folder. I would add instructions to your Readme file and sandbox page with the download link and to rename the downloaded folder, jquery.booklet.version#, to just booklet and to place it in the libraries folder.

Rob

I'm getting the following error when I try to add any of the Publication Page fields:
"Add new field: you need to select a widget."

Also, do I need to add the pdfparser PHP library, https://github.com/smalot/pdfparser?
I noticed a call to it in the code.

Just changing the status since it looks like some work needs to be done.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.