Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment field instance settings has "default_mode" to switch threading for comments.
Switch it to COMMENT_MODE_FLAT
as all forums use
Comment | File | Size | Author |
---|---|---|---|
#18 | forum-comments-non-threaded-2301247-18.patch | 1.08 KB | mitsuroseba |
Comments
Comment #1
sjancich CreditAttribution: sjancich commentedComment #2
larowlanDo we need a test?
Comment #3
andypostWould be good to have a test
Comment #4
andypostSuppose the quick fix here is to change setting in
hook_install()
Comment #5
mitsuroseba CreditAttribution: mitsuroseba commentedComment #9
andyposttested this locally and no failures detected
Comment #10
andypostComment #12
jthorson CreditAttribution: jthorson commentedGET http://10.20.0.214/checkout/checkout/comment/reply/node/1/comment_forum/1 returned 404 (3.69 KB).
Note the duplicate 'checkout' in the URL ... that should not be there. The testbot installs in a subdirectory (i.e. not at the web root), whereas I suspect your local tests which are passing are on a site installed at '/'.
The verbose output for the failed tests is a 'Page not found'.
Comment #13
mitsuroseba CreditAttribution: mitsuroseba commentedThank you, @jthorson!
Comment #14
mitsuroseba CreditAttribution: mitsuroseba commentedinterdiff.
Comment #15
andypostGreat! @larowlan are you agree?
Comment #16
larowlanFine by me
Comment #17
alexpottI don;t think we need to tests in the Forum module for non threaded comments - this is extensively tested elsewhere - we're just using another module's API here.
Comment #18
mitsuroseba CreditAttribution: mitsuroseba commentedThank you, @alexpott!
Remove test.
Comment #19
andypostback to rtbc
Comment #20
alexpottCommitted dc11fb9 and pushed to 8.0.x. Thanks!