Make comments for forum non-threaded by default

Do we need a test?

GET http://10.20.0.214/checkout/checkout/comment/reply/node/1/comment_forum/1 returned 404 (3.69 KB).

Note the duplicate 'checkout' in the URL ... that should not be there. The testbot installs in a subdirectory (i.e. not at the web root), whereas I suspect your local tests which are passing are on a site installed at '/'.

The verbose output for the failed tests is a 'Page not found'.

Thank you, @jthorson!

interdiff.

Fine by me

1. +++ b/core/modules/forum/src/Tests/ForumTest.php
   @@ -469,6 +469,31 @@ function testForumWithNewPost() {
      /**
   +   * Tests that forum comments have COMMENT_MODE_FLAT instead of threading mode.
   +   */
   +  function testCommentFlatMode() {
   +    // Login as the first user.
   +    $this->drupalLogin($this->admin_user);
   +    // Create a forum container.
   +    $this->forumContainer = $this->createForum('container');
   +    // Create a forum.
   +    $this->forum = $this->createForum('forum');
   +    // Create a topic.
   +    $node = $this->createForumTopic($this->forum, FALSE);
   +
   +    $this->drupalLogin($this->post_comment_user);
   +    // Post a reply to the topic.
   +    $edit = array();
   +    $edit['subject[0][value]'] = $this->randomName();
   +    $edit['comment_body[0][value]'] = $this->randomName();
   +    $this->drupalPostForm('node/' . $node->id(), $edit, t('Save'));
   +
   +    $this->drupalPostForm('comment/reply/node/'. $node->id() . '/comment_forum/1', $edit, t('Save'));
   +    $indented = $this->cssSelect('div .indented .comment');
   +    $this->assertTrue(empty($indented), 'Check that comment display in flat mode');
   +  }
   

   I don;t think we need to tests in the Forum module for non threaded comments - this is extensively tested elsewhere - we're just using another module's API here.

Thank you, @alexpott!
Remove test.

Committed dc11fb9 and pushed to 8.0.x. Thanks!