Just a quick fix to implement to avoid this strict warning:

Line 261, change this:

$mode = reset(array_keys($modes));

by this:

$modes_keys = array_keys($modes);
$mode = reset($modes_keys);

Just apply the patch & voilà ;)

CommentFileSizeAuthor
#3 asset-strict_warning_fix-2300259-3-D7.patch491 bytesgurvan
#2 asset-strict_warning_fix-2300259-2-D7.patch.txt484 bytesgurvan
#1 asset-strict_warning_fix-2300259-D7.patch481 bytesgurvan

Comments

gurvan’s picture

gurvan commented
Issue summary: View changes
StatusFileSize
new asset-strict_warning_fix-2300259-D7.patch481 bytes
gurvan’s picture

gurvan commented
StatusFileSize
new asset-strict_warning_fix-2300259-2-D7.patch.txt484 bytes

Just a little update to avoid a bug with asset view mode selection

gurvan’s picture

gurvan commented
StatusFileSize
new asset-strict_warning_fix-2300259-3-D7.patch491 bytes

My bad...

Another little fix, I guess now it can be commited in dev

gurvan’s picture

gurvan commented
Issue summary: View changes
sinn’s picture

sinn commented
Status: Active » Reviewed & tested by the community

Patch #3 works good.

IRuslan’s picture

IRuslan commented

Hi,

thanks for catch this.
But from my point of view, as we need to get first key of the $modes array here, it's more suitable to use:

reset($modes);
$mode = key($modes);

Because we don't need to allocate a separate array for keys.

IRuslan’s picture

IRuslan commented
Status: Reviewed & tested by the community » Fixed

Committed to dev.

  • IRuslan committed 28c39ef on 
    Issue #2300259 by gurvan, sinn, IRuslan: Strict warning: Only variables...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.